search

Scirra / Construct-bugs

Public bug report submissions for Construct 3 and Construct Animate. Please read the guidelines then click the 'Issues' tab to get started.
https://www.construct.net
107 stars 83 forks source link

[Whitelist] Build Service plugin support request. #3130

Closed Chadori closed 4 years ago

Chadori commented 5 years ago

Hi. I would like to request support for a few plugins, to wit:

Update

Add

Add#2

Add#3

For consideration Just in case it's already feasible to support..

I finally want all my addons to get supported by the C3 Build Service and update the existing ones, so that the users, including me, won't have to always rely on PhoneGap and be able to build directly.

I hope the long list is alright with you @shortercode 😁 .

Thank you.

shortercode commented 5 years ago

cordova-plugin-googleplus@5.3.1 is already on the whitelist, do you specifically need the older version as well? The latest version is 7.0.2

Chadori commented 5 years ago

Ohh, this is a typo. Sorry. I meant, cordova-plugin-googleplus@7.0.2. Edited.

Chadori commented 5 years ago

Hi. Is this good to go? 🙂

shortercode commented 5 years ago

I'm about halfway through the list, had a few things on last week and had Friday off. Will let you know next week hopefully

On Sun, 21 Jul 2019, 17:27 ChadoriRebornXD, notifications@github.com wrote:

Hi. Is this good to go? 🙂

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Scirra/Construct-3-bugs/issues/3130?email_source=notifications&email_token=ACFB5WNTIBNER4CORG5YV23QASFAPA5CNFSM4IC32WPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2OG4ZY#issuecomment-513568359, or mute the thread https://github.com/notifications/unsubscribe-auth/ACFB5WM4MZINKUCVQXNXSJLQASFAPANCNFSM4IC32WPA .

Chadori commented 5 years ago

@shortercode it's fine. Thank you very much!

KekGames commented 5 years ago

@shortercode do you plan to update and add everything at once, or maybe plugins that you have already reviewed could be updated earlier?

shortercode commented 5 years ago

I've updated the whitelist for the following plugins so far:

dop2000 commented 5 years ago

@shortercode , Thanks for doing this! Could you please give an estimate on when these two plugins will be added? cordova-plugin-admob-free (0.27.0) cordova-admob-sdk (0.24.1)

shortercode commented 5 years ago

I've added a further 3 to the whitelist:

@dop2000 it's probably going to be a few weeks, due to staff leave. There's a large number of the admob related plugins which are potentially dangerous, so may not pass. We're investigating if we can make adjustments to safely use them.

Chadori commented 5 years ago

@shortercode Thank you very much, hoping for the others too.

Chadori commented 5 years ago

Hi @shortercode , I plan to write a couple of mediation Cordova plugins.

What determines compatibility with the C3 Build Service? I remember you mentioning restricting some dependencies for some unpredictable behavior.

Do I need to look out for something? Thanks.

JeFawk commented 5 years ago

Having these supported would be a great addition!

shortercode commented 5 years ago

It's not so much about compatibility, they will work but we cannot consider them safe. The review basically covers 2 main restrictions:

  1. Dependencies are reproducible - i.e. no dependency will automatically update, with the exception of trusted sources ( i.e. play-games-services )
  2. Only simple build scripts with obvious meaning are accepted

It's normally the first which is the one that plugins get held up on. It's not a particularly restrictive policy, but perhaps not one which 3rd party developers aim for.

Chadori commented 5 years ago

@shortercode Ohh I see. I understand.

On our part, Cordova plugins are time consuming to develop and maintain, hence there are barely any publicly available ones for each feature, and the authors are not aware of the Construct Build Service's requirements. We are only lucky If someone already has made one for each feature, but if it turns out to have non-straightforward scripts or dependencies, then that feature would be out of our reach. And I don't think they would bother to change their plugin on our behalf.

We really would try to adjust and create our own Cordova plugins on some implementations practical for us, but it's nearly impossible to replicate some features like services or redo already well-established plugins.

I hope there was an easier way for this, where we can take advantage of the little available plugins we could use, but I understand that this for the safety and reliability of the build service.

Thanks for the information.

@shortercode If it's alright, I would like to request the change of version of the plugin:

This is for the compatibility of Construct 3's Google Play plugin, thank you again!

shortercode commented 5 years ago

I agree that it's problematic finding suitable cordova plugins for features. The plugin ecosystem is a bit of a mess, even with "good" plugins maintenance is slow and many are either abandoned, outdated or just badly written. We're now maintaining several plugins and have plans for more, but they are quite time consuming to keep up to date.

Yesterday I came up with a potential way of allowing us to tweak each plugin slightly, so that they meet the requirements. I'm trying to decide the feasibility of it at the moment. But it wouldn't guarantee compat. with every plugin.

Chadori commented 5 years ago

We're now maintaining several plugins and have plans for more, but they are quite time consuming to keep up to date.

Yesterday I came up with a potential way of allowing us to tweak each plugin slightly, so that they meet the requirements. I'm trying to decide the feasibility of it at the moment. But it wouldn't guarantee compat. with every plugin.

That's great thanks.

Chadori commented 5 years ago

Hi, I would like to request an update for a plugin:

Thanks.

shortercode commented 5 years ago

Will add it onto the list.

New system is coming along well, hoping to have it on production this week.

Chadori commented 5 years ago

@shortercode That's great news! Thanks!

Chadori commented 5 years ago

Hi, also pushwoosh-cordova-plugin@7.18.1 updated to a new version for an important fix. Thanks again!

Chadori commented 5 years ago

I nearly forgot : pushwoosh-geozones-cordova-plugin@1.17.0. Thanks again!

shortercode commented 5 years ago

The dependency upgrade is complete, however we have delayed launch because of a Cordova bug. We had previously worked around it but apparently it has become a problem again. As the upgrade was quite a time sink I have put this aside for the time being. But I'm hoping to return to it once some other high priority issues have been resolved.

On a positive note the new system has allowed several plugins which were deemed risky under the old system to pass security review. I'm hoping it will also allow for faster builds, but further testing will be required for that.

Chadori commented 5 years ago

@shortercode It's alright and thank you for working on it!

Also, I would like to request an update to the Facebook addon. cordova-plugin-facebook4 : @6.0.0

Thanks!

Chadori commented 5 years ago

Also these: cordova-plugin-badge@0.8.8 cordova-plugin-android-notch@1.0.3 cordova-plugin-cutout@1.0.10

Sorry for the workload, but we're really enjoying Construct. 🙂 Thanks again.

masscube commented 4 years ago

Can you add this too, please? https://www.npmjs.com/package/cordova-plugin-email Thx :)

Chadori commented 4 years ago

Hi, I need to update this plugin's version pushwoosh-cordova-plugin@7.18.3. Causing build errors without the update. Thanks.

ERAgames777 commented 4 years ago

When will admob mediation cordova-plugin-admob-mediation plugins and intermediary advertising networks plugins work with c3build?

Chadori commented 4 years ago

If it's already feasible: onesignal-cordova-plugin@latest_version_when_implemented

Thanks.

masscube commented 4 years ago

@shortercode Is there a list what plugins are now supported?

shortercode commented 4 years ago

@masscube we don't have a public list at this time, I'll bring it up with the team so we can discuss it.

Chadori commented 4 years ago

cordova-plugin-network-information@latest_version_when_implemented, thanks!

shortercode commented 4 years ago

A public list is now available on the SDK forum https://www.construct.net/en/forum/construct-3/plugin-sdk-10/build-server-cordova-plugin-149266

masscube commented 4 years ago

@shortercode can you add cordova-plugin-email @latest_version please!

shortercode commented 4 years ago

While I appreciate that this bug is listed in a very general way, and has yet to be closed, I would prefer if requests could go in new issues. This way we can track which ones have been completed.

masscube commented 4 years ago

@shortercode Ok, here my new request: https://github.com/Scirra/Construct-3-bugs/issues/3583

shortercode commented 4 years ago

cordova-plugin-network-information@2.0.2 has been added to the whitelist.

shortercode commented 4 years ago

onesignal-cordova-plugin@2.8.1 has been added to the whitelist

shortercode commented 4 years ago

I've been trying to go back through this list thread, but it's grown unwieldy. As per my comment to @masscube it's better to post requests as new issues rather than comments so that it's easier for us to manage.

@ChadoriRebornXD could you confirm which versions of plugins you are still waiting on?

shortercode commented 4 years ago

@ERAgames777 I believe the mediation and lycwed plugins failed the security review.

Internally we have an enhancement project that we hoped would enable us to be less strict on security reviews, but it has hit a number of deadends due to unfortunate behaviours in the cordova toolchain. We haven't cancelled it, but it's on hold at the moment. That project was the primary reason this issue was kept open, instead of just listing a dozen or so plugins as having failed review.

I understand that you would like us to support them but crossposting about it in other issues will not enable us to support them any faster.

shortercode commented 4 years ago

@ChadoriRebornXD I reviewed pushwoosh-cordova-plugin@7.18.5 ( latest) and it passed. Are you happy with that version, or do you specifically want 7.18.3?

Chadori commented 4 years ago

@shortercode 7.18.5 is perfect, thanks!

shortercode commented 4 years ago

pushwoosh-cordova-plugin@7.18.5 has been added to the whitelist

shortercode commented 4 years ago

I'm we're going to close this issue. We've added all the ones that passed review to the whitelist. If anyone would like to request a particular plugin is added to the whitelist then please file a new report. I've marked this report with a new label to indicate that their are some plugins listed here that couldn't be added. In future if plugins cannot be added to the list for some reason it should be marked with this label.

If we make any changes in the future that reduce the restrictions then we can revisit the issues closed with this label.

Chadori commented 4 years ago

@shortercode Not much we can do if it can't be passed. I'll adjust for now and find some possible alternatives. Thanks for the hard work on the currently passed ones and the list.