search

Scirra / Construct-bugs

Public bug report submissions for Construct 3 and Construct Animate. Please read the guidelines then click the 'Issues' tab to get started.
https://www.construct.net
107 stars 83 forks source link

Whitelist plugins #4374

Closed Chadori closed 3 years ago

Chadori commented 3 years ago

Hi, kindly whitelist the following plugins:

chadori-mobile-facebook@0.0.1 chadori-mobile-background@0.0.1 cordova-launch-review@4.0.1 chadori-mobile-ironsource-adcolony@0.0.4 chadori-mobile-ironsource-admob@0.0.4 chadori-mobile-ironsource-amazon@0.0.4 chadori-mobile-ironsource-applovin@0.0.5 chadori-mobile-ironsource-chartboost@0.0.4 chadori-mobile-ironsource-facebook@0.0.4 chadori-mobile-ironsource-fyber@0.0.4 chadori-mobile-ironsource-hyprmx@0.0.4 chadori-mobile-ironsource-inmobi@0.0.4 chadori-mobile-ironsource-maio@0.0.4 chadori-mobile-ironsource-pangle-cn@0.0.1 chadori-mobile-ironsource-pangle@0.0.4 chadori-mobile-ironsource-tapjoy@0.0.4 chadori-mobile-ironsource-unityads@0.0.4 chadori-mobile-ironsource-vungle@0.0.4

Thank you.

AshleyScirra commented 3 years ago

Build service now updated to allow all requested plugins. However cordova-launch-review@4.0.1 was omitted since it appears to duplicate the built-in Share plugin's existing ability to open store reviews. There don't need to be third-party plugins reimplementing existing built-in features, they will only cause compatibility problems. However if the plugin does something different to the built-in feature, please explain and I can reconsider.

Chadori commented 3 years ago

Hi @AshleyScirra,

Yes, it actually runs a bit differently in the background. Construct 3 seems to do things in a straight-forward fashion, launch rating and review, which is good for ease of use.

However, this plugin supports more advanced features, like callbacks, statuses and device conditions, which we have freedom to do more flexible implementations. Also, the addon did come first before Construct 3 had a review feature, so removing the mentioned features would be a redesign of our existing apps, and other existing users of the addon.

I hope you understand, thanks.

AshleyScirra commented 3 years ago

Is this for a paid addon? What I would want to avoid is Construct users thinking they have to pay extra to get the ability to launch a rating/review, when the built-in addon can do that at no further cost. On your side too, I would guess you want to avoid the case where someone pays for your addon to get the ability to launch a rating/review, and then realises they didn't have to pay because it's built in - then you probably have an angry customer. These are pretty bad support situations I want to avoid (and hope you do too).

Chadori commented 3 years ago

Yeah, I think I'll start deprecating it.

However, is it possible to whitelist this last version? There are existing users of the addon, including me, that just want to update their apps and use the previously mentioned features. We have UI that rely on those features.

AshleyScirra commented 3 years ago

Oh, I didn't realise until now an older version of cordova-launch-review was already allowed. Since it's just a maintenance update I've updated the build service to allow 4.0.1, but as noted I'll probably remove this in future since it's now built-in.

Chadori commented 3 years ago

Thanks! That helps a lot, while we transition to the official one.