search

Scirra / Construct-bugs

Public bug report submissions for Construct 3 and Construct Animate. Please read the guidelines then click the 'Issues' tab to get started.
https://www.construct.net
107 stars 83 forks source link

Whitelist plugins #4747

Closed Chadori closed 3 years ago

Chadori commented 3 years ago

Hi, please update the addons below.

chadori-mobile-ironsource
chadori-mobile-ironsource-debug
chadori-mobile-ironsource-adcolony
chadori-mobile-ironsource-admob
chadori-mobile-ironsource-amazon
chadori-mobile-ironsource-applovin
chadori-mobile-ironsource-chartboost
chadori-mobile-ironsource-facebook
chadori-mobile-ironsource-fyber
chadori-mobile-ironsource-hyprmx
chadori-mobile-ironsource-inmobi
chadori-mobile-ironsource-maio
chadori-mobile-ironsource-pangle
chadori-mobile-ironsource-pangle-cn
chadori-mobile-ironsource-tapjoy
chadori-mobile-ironsource-unityads
chadori-mobile-ironsource-vungle
chadori-mobile-ironsource-smaato
chadori-mobile-ironsource-snap

All versions in 0.7.0.

Thank you!

muratkakar commented 3 years ago

Esteemed Ashley, we are unable to make our most important updates due to problems with our Admob ads, so if you can prioritize the whitelist, it will be very appreciated, thank you very much in advance for your support on this issue. Best regards.

AshleyScirra commented 3 years ago

@Chadori - you've been making a lot of these requests lately, and every time you post one it creates a lot of review work which is painful for us as a small team with plenty of other things that need working on, especially as you are now requesting review for 19 separate Cordova plugins. Please consider reducing the number of plugins or designing them to reduce the frequency of requests. If you are going to request ~20 plugin updates every ~2 weeks, I will probably start slowing down the rate at which I approve them in order to reduce the workload on us. For example I may just review your latest request once every 2 months, so we don't have to do all this work more than once every 2 months.

iYonga commented 3 years ago

@Chadori - you've been making a lot of these requests lately, and every time you post one it creates a lot of review work which is painful for us as a small team with plenty of other things that need working on, especially as you are now requesting review for 19 separate Cordova plugins. Please consider reducing the number of plugins or designing them to reduce the frequency of requests. If you are going to request ~20 plugin updates every 2 weeks, I will probably start slowing down the rate at which I approve them in order to reduce the workload on us. For example I may just review your latest request once every 2 months, so we don't have to do all this work more than once every 2 months.

We understand you but a lot of people depend on the tools and plugins that extend the native features of Construct. Like google play authentication, playfab integration and a lot of ad plugins. I think 1 month would be acceptable but I'm not Chadori.

AshleyScirra commented 3 years ago

It's not clear why so many requests are necessary in the first place. If there are issues actively causing problems that people keep running in to, an update can be requested for the specific single plugin affected. If it's just bumping to the latest patch releases of various libraries for the sake of routine maintenance, that's probably not actually that important. Routine maintenance can be done more infrequently, such as once a quarter, and would save imposing a significant review workload on us.

Perhaps I should ask for clarification on these requests: is it routine maintenance, or to address an important issue? I think if it's just routine maintenance, we will only review it every 2-3 months to keep the workload down.

iYonga commented 3 years ago

It's not clear why so many requests are necessary in the first place. If there are issues actively causing problems that people keep running in to, an update can be requested for the specific single plugin affected. If it's just bumping to the latest patch releases of various libraries for the sake of routine maintenance, that's probably not actually that important. Routine maintenance can be done more infrequently, such as once a quarter, and would save imposing a significant review workload on us.

Perhaps I should ask for clarification on these requests: is it routine maintenance, or to address an important issue? I think if it's just routine maintenance, we will only review it every 2-3 months to keep the workload down.

It isn't possible to export with the build service at all. So it is a serious bug fix.

AshleyScirra commented 3 years ago

Is it really all of them, or just some of them? And how is it that this happened just a couple of weeks after approving the last set of plugins? None of the other Cordova plugins Construct uses have anywhere near this frequency of breakage or updates.

Edit: there are also entirely new Cordova plugins being requested here. So it looks like a feature update, not essential maintenance, and therefore is not time sensitive. If there is a small part of it that is essential maintenance, and the rest is routine maintenance or feature updates, it would be better to separate this out in to two separate requests. I could do a small essential request quickly, and do the larger routine maintenance/feature update requests on a slower schedule, which should not be particularly impactful to users. However if some small essential fixes are thrown in to a big batch of routine maintenance and feature updates, I will treat it all on a routine maintenance schedule, and take longer to review it.

muratkakar commented 3 years ago

Dear Ashley, I do not know java scripts and similar scripts, I devoted myself and my life to construct 3 because of its ease. I do not know special coding, so I can even use ads with plugins. I'm sure Chadori will explain to you, but Admob is my only ad revenue source, and I don't even know what cordova cli means that I don't have the capacity and ability to fix export using it, so any support you can do on these issues is a great deal for the construct user. will help. We know that you have worked hard and we cannot thank you enough for this situation. Best regards.

I used the English from the translator. Sorry for my broken English.

iYonga commented 3 years ago

I used the English from the translator. Sorry for my broken English.

@muratkakar For your information, there is a Turkish community for Construct.

https://discord.gg/NF2MGz9

Chadori commented 3 years ago

Hi @AshleyScirra, that's my fault. I apologize, that must have been tough on your end.

I've mentioned before that I was trying out different unusual ways to always use the latest dependencies, in hopes of always using the latest SDK versions while not needing whitelisting, well it worked for a while, but that backfired with the latest SDK versions that broke all existing plugin versions I have in the build service. This was to accommodate frequent update requests from different users, I'm sure you understand.

You mentioned designing it again to not frequently need updates. Hopefully this is some good news, these 0.7.0 are now using static dependencies, so whatever happens they will remain stable for a long time. I just need one version (0.7.0) working in the build service. I hope you understand.

I will follow the maintenance routine of minimum of 2~3 months, that is fair enough considering the work load.

Thank you!

AshleyScirra commented 3 years ago

It's still not clear which part of this request is essential maintenance, and which part is routine maintenance or adding new features, since there are definitely new feature requests here as there are entirely new Cordova plugins being requested. Please split this in to two separate issues according to essential and non-essential updates. I'm closing this issue in order to make sure you file new issues accordingly.

This was to accommodate frequent update requests from different users, I'm sure you understand.

Sometimes users tell us that we should update various libraries or dependencies to the latest version, even if just some minor routine maintenance was done which would not actually affect anything. We usually do not immediately act on such requests if there is no evidence they are important. You should not have to either. They can be done infrequently as part of routine maintenance. Non-technical users are not always aware of the distinction between important updates and minor updates.

Chadori commented 3 years ago

Thank you, I will continue on a new thread.