Make MarkAsProcessed thread safe

[jeremy001181]

Good point! thanks, I will make an update accordingly and probably add some tests around this scenario as well.

On Thu, 20 Dec 2018 at 08:13, Marcin Kral notifications@github.com wrote:

@krlm commented on this pull request.

In src/QueueBatch/Impl/MessageBatch.cs https://github.com/Scooletz/QueueBatch/pull/10#discussion_r243184195:

     {

var tasks = new Task[messages.Length];

• var messagesToDelete = processed.ToList();

ConcurrentBag accepts duplicates, which is not a problem for Delete I guess, however ReleaseMessage and MoveToPoisonQueue doesn't look like idempotent operations, so what do you think about:

var messagesToDelete = new HashSet(processed);

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Scooletz/QueueBatch/pull/10#pullrequestreview-186884518, or mute the thread https://github.com/notifications/unsubscribe-auth/ACO9hZsefblyaQLdkhBehSZMS_dfOK30ks5u60a8gaJpZM4ZaCkt .

-- Zhongming Chen

[Scooletz]

Oh my, I needed to unroll the comment as it was done in the original branch I suppose :-) Is this Work In Progress then, @jeremy001181 ?

[krlm]

@Scooletz sorry for confusion, I've deleted my original comment because I got tricked by diff, actually @jeremy001181 change is not relevant for ReleaseMessage and MoveToPoisonQueue. However, using a hashset/distinct there might help to avoid superfluous calls to queue client.

[Scooletz]

Replaced by #11