Connection setting handling

Scooletz / QueueBatch

WebJobs/Azure Functions trigger providing batches of Azure Storage Queues messages directly to your function

Apache License 2.0

41 stars 4 forks source link

Connection setting handling #6

Closed krlm closed 5 years ago

krlm commented 5 years ago

This PR adds handling of connection setting of queue storage in a similar way as it's done by regular QueueTrigger.

krlm commented 5 years ago

@Scooletz I've fixed all of above issues. Am I supposed to mark those conversations as resolved or just wait for further review? (I'm not really familiar with github reviews workflow)

Scooletz commented 5 years ago

Nope. Let me review it tomorrow in the morning, rerun the tests, etc. Once I'm done, I'll merge it.

Thank you again for introducing this feature 🤗

Scooletz commented 5 years ago

@krlm I added a few minor fixes in here: https://github.com/krlm/QueueBatch/pull/1 If you could accept it (squash-merge) preferred, I'd accept this one. Maybe I could have propose all the changes in here, but it was easier for me to get this as a PR for your PR.

Scooletz commented 5 years ago

Thank you @krlm for bringing it! 🤗