ScoopInstaller / Extras

📦 The Extras bucket for Scoop.
https://scoop.sh
The Unlicense
1.78k stars 1.34k forks source link

[Bug]: Firefox Private Browsing shortcut isn't contained in the Scoop Apps folder #10777

Open mariobrostech opened 1 year ago

mariobrostech commented 1 year ago

Prerequisites

Package Name

firefox

Expected/Current Behaviour

I expected for the Firefox Private Browsing shortcut to appear within the Scoop Apps folder in the Start Menu. Instead, it appears in the root of the Start Menu, which doesn't follow the conventions of other Scoop applications.

Steps to Reproduce

PS C:\Users\User> scoop install firefox
Installing 'firefox' (111.0) [64bit] from extras bucket
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: 4c4821|OK  |    12MiB/s|C:/Users/User/scoop/cache/firefox#111.0#https_archive.mozilla.org_pub_firefox_releases_111.0_win64_en-US_Firefox_20Setup_20111.0.exe_dl.7z
Download: Status Legend:
Download: (OK):download completed.
Checking hash of Firefox%20Setup%20111.0.exe ... ok.
Extracting dl.7z ... done.
Linking ~\scoop\apps\firefox\current => ~\scoop\apps\firefox\111.0
Creating shim for 'firefox'.
Creating shortcut for Firefox (firefox.exe)
Creating shortcut for Firefox Profile Manager (firefox.exe)
Persisting distribution
Persisting profile
Running post_install script...
'firefox' (111.0) was installed successfully!

Possible Solution

I have created a pull request that I will link to this issue shortly which addresses the problem described above.

Scoop and Buckets Version

PS C:\Users\User> scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
1aea899aa (HEAD -> master, origin/master, origin/HEAD) armcord@3.1.7: Fix hash (Closes #10776)

'games' bucket:
4fcb4ace (HEAD -> master, origin/master, origin/HEAD) yuzu: Update to version 0-1371

'main' bucket:
be243a060 (HEAD -> master, origin/master, origin/HEAD) terraform: Update to version 1.4.1

'nonportable' bucket:
4a883dc (HEAD -> master, origin/master, origin/HEAD) 10x-np: Update to version 0.36.13

Scoop Config

PS C:\Users\User> scoop config

last_update        aria2-warning-enabled scoop_branch scoop_repo
-----------        --------------------- ------------ ----------
3/15/2023 14:14:51                 False master       https://github.com/ScoopInstaller/Scoop

PowerShell Version

PS C:\Users\User> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.3.3
PSEdition                      Core
GitCommitId                    7.3.3
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

HUMORCE commented 1 year ago

It is generated when the program is run, which not when installed.