ScoopInstaller / Extras

📦 The Extras bucket for Scoop.
https://scoop.sh
The Unlicense
1.78k stars 1.34k forks source link

[Bug]: Telegram manifest autoupdate is failing #11791

Closed leumasme closed 1 year ago

leumasme commented 1 year ago

Prerequisites

Package Name

telegram

Expected/Current Behaviour

The latest version of telegram for windows is 4.9.2, which was released 3 days ago. The current version in the manifest is 4.9.1 Checking why the manifest checkver didnt work revealed the issue: version 4.9.3 was released very shortly after, but it is a MacOS-Only hotfix, so no windows builds are provided. Scoop tries to update the manifest to 4.9.3, but fails since the file for hash calculation isn't found. https://github.com/telegramdesktop/tdesktop/releases

Steps to Reproduce

❯ & "$env:scoop/apps/scoop/current/bin/checkver" -App "$env:scoop/buckets/extras/bucket/telegram.json" -Update
telegram: 4.9.3 (scoop version is 4.9.1) autoupdate available
Autoupdating telegram
Downloading tportable.4.9.3.zip to compute hashes!
The remote server returned an error: (404) Not Found.
URL https://github.com/telegramdesktop/tdesktop/releases/download/v4.9.3/tportable.4.9.3.zip is not valid
ERROR Could not update telegram, hash for tportable.4.9.3.zip failed!

Possible Solution

Simply waiting until the next telegram release would be possible, but this issue would likely resurface occasionally since macos-only hotfixes are not a rare thing from looking at the telegram releases page. Perhaps a custom checkver script to target only the latest version that has a windows release availble?

Scoop and Buckets Version

❯ scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
e0745a56a (HEAD -> master, origin/master, origin/HEAD) attribute-changer: Add version 11.10 (#9549)

'games' bucket:
7f4bec38 (HEAD -> master, origin/master, origin/HEAD) yuzu: Update to version 0-1537

'java' bucket:
b6a8c3bb (HEAD -> master, origin/master, origin/HEAD) temurin8-nightly-jre: Update to version 8.0.392-3.0.202308241706

'main' bucket:
31e0aa825 (HEAD -> master, origin/master, origin/HEAD) terragrunt: Update to version 0.50.8

'nirsoft-alt' bucket:
988ccc8 (HEAD -> master, origin/master, origin/HEAD) Update url list [ci skip]

'versions' bucket:
25671177d (HEAD -> master, origin/master, origin/HEAD) github-beta: Update to version 3.2.10-beta2

Scoop Config

❯ scoop config

last_update     : 25.8.2023 19:19:27
aria2-enabled   : False
alias           : @{i=scoop-i; ls=scoop-ls; s=scoop-s; up=scoop-up}
cat_style       : grid,numbers
show_update_log : False
scoop_repo      : https://github.com/lukesampson/scoop
scoop_branch    : master

PowerShell Version

❯ $psversiontable

Name                           Value
----                           -----
PSVersion                      7.3.6
PSEdition                      Core
GitCommitId                    7.3.6
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

HUMORCE commented 1 year ago

Upstream released 2 versions in 2 hours, and the latest version does not include a windows build.

A large number of manifests in the Extras bucket, In this case, even if the Extractor is executed every 2 hrs, the version 4.9.2 may still be ignored.

Perhaps a custom checkver script to target only the latest version that has a windows release availble?

no, unless it happens often.