[Bug]: The CudaText plugins was not persisted after update

rumia-san commented 9 months ago

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

cudatext

Expected/Current Behaviour

After update cudatext, the installed plugins were all lost. The reason is that the plugins in cudatext is under the "py" folder, which is not persisted in scoop

Steps to Reproduce

1. Install an old version cudatext
2. Install a plugin via cudatext's plugin manager
3. Update the cudatext
4. The installed plugin was gone

Possible Solution

I'm not sure, maybe we could set the "py" folder as “persist”. However, the preinstalled plugins in this folder might be updated as well when the cudatext is updated.

Scoop and Buckets Version

Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
17ca8f392 (HEAD -> master, origin/master, origin/HEAD) youtube-music: Update to version 3.1.0

'main' bucket:
eabbf9a5d (HEAD -> master, origin/master, origin/HEAD) p4@2023.2-2523307: Fix hash (Closes #5339)

Scoop Config

aria2-enabled last_update                       scoop_branch scoop_repo
------------- -----------                       ------------ ----------
         True 2023-12-11T12:01:13.6470730+08:00 master       https://github.com/lukesampson/scoop

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.19041.3693
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.3693
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

No response

amorphobia commented 5 months ago

It seems data folder contains language, lexer, themes, etc. also need to be persisted.

However, there are pre-installed plungins (languages, lexers ...) in py and data folders. Persisting whole folders might prevent updating them.

Maybe we can persist all three folders (settings, py, data), and replace existing files with files in new zip to update.

amorphobia commented 4 months ago

A similar issue found for msys2: ScoopInstaller/Main#3689

ScoopInstaller / Extras