ScoopInstaller / Extras

📦 The Extras bucket for Scoop.
https://scoop.sh
The Unlicense
1.78k stars 1.33k forks source link

[Bug]: Cleanup Command deletes all Floorp data #12958

Open WNnitro opened 5 months ago

WNnitro commented 5 months ago

Prerequisites

Package Name

Floorp

Expected/Current Behaviour

I'm trying to run scoop cleanup * to delete previous installations of my packages. However, this command deletes the Profiles folder of my Floorp installation instead, which is not what im expecting. img-2024-03-15-18-19-05

Steps to Reproduce

1. Install Scoop
2. run 'scoop bucket add extras'
3. run 'scoop install extras/floorp'
4. open Floorp, close it.
5. run 'scoop cleanup *'

Possible Solution

not deleting the profiles folder.

Scoop and Buckets Version

PS C:\Users\Administrator> scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
2a36a45d4 (HEAD -> master, origin/master, origin/HEAD) tidal: Add version 2.36.2 (#12941)

'LuoHuiRu_ScoopBucket' bucket:
3fdae5c (HEAD -> master, origin/master, origin/HEAD) VSCode-Nightly: Update to version 1.88.0-insider_1710392702683

'main' bucket:
471486b0d (HEAD -> master, origin/master, origin/HEAD) oh-my-posh: Update to version 19.17.2

'nerd-fonts' bucket:
db6ccd1 (HEAD -> master, origin/master, origin/HEAD) LXGWNeoXiHei@1.120.1: Fix hash (Closes #280)

'nonportable' bucket:
25964b17 (HEAD -> master, origin/master, origin/HEAD) office-365-apps-minimal-np: Update to version 0.7.7.0

'okibcn_ScoopMaster' bucket:
f86fdde1b3 (HEAD -> master, origin/master, origin/HEAD) Update timestamp 2024-03-15T10:52:54Z

'versions' bucket:
749fc6345 (HEAD -> master, origin/master, origin/HEAD) zig-dev: Update to version 0.12.0-dev.3303

Scoop Config

scoop config

last_update                       alias                      scoop_branch scoop_repo
-----------                       -----                      ------------ ----------
2024-03-15T21:48:45.4486962+07:00 @{outdated=scoop-outdated} master       https://github.com/ScoopInstaller/Scoop

PowerShell Version

PS C:\Users\Administrator> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.22621.2506
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.2506
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

Floorp

SegoCode commented 2 months ago

Hello,

That happens because the manifest has been reused from Firefox and all its forks, but the portable version in this case

https://github.com/ScoopInstaller/Extras/blob/8f7ba900c387b81d1ce8c1b073439a065fd524c4/bucket/floorp.json#L14

Unlike other Firefox forks, this portable version of Floorp creates a whole directory tree simulating the appdata. Therefore, the persist folder doesn't match with the application data.

Scoop app imagen

Scoop persist imagen

I dont recommend make a script in the manifest to create and persist this entire directory tree. Instead, download the installer version from https://github.com/Floorp-Projects/Floorp/releases/download/v11.14.1/floorp-win64.installer.exe, extract it like a zip and get the 'core' folder. This way, easier to maintain, the script for this 'Firefox' will be the same as for the other 'Firefox' versions, with that, this actual note make sense:

Notes
-----
To set profile 'Scoop' as *DEFAULT*, or profiles/settings was lost after update:
- Run 'Floorp Profile Manager', choose 'Scoop' then click 'Start Floorp'.
- Visit 'about:profiles' page in Floorp to check *DEFAULT* profile.
For details:
https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

Currently even the "scoop" profile was not created.