ScoopInstaller / Extras

📦 The Extras bucket for Scoop.
https://scoop.sh
The Unlicense
1.79k stars 1.35k forks source link

[Bug]: Tor Browser not opening #13324

Open otavio-silva opened 4 months ago

otavio-silva commented 4 months ago

Prerequisites

Package Name

tor-browser

Expected/Current Behaviour

When installed though Scoop, the Tor Browser does not open. Double-clicking it makes the process appear in task manager for a brief second and it vanishes. Nothing is showing in the event logs, and the same behavior does not occur when downloading the .exe file and installing it myself.

Steps to Reproduce

1. Run `scoop install extras/tor-browser`
2. Go to `~\scoop\apps\tor-browser\current\`
3. Run `firefox.exe`
4. Nothing happens

Possible Solution

I have no idea. Maybe there's something going on in ~\scoop\persist\tor-browser\TorBrowser\Data\Browser\profile.default, but that's a wild guess.

Scoop and Buckets Version

Current Scoop version:
d337bb1f (HEAD -> master, tag: v0.4.2, origin/master, origin/HEAD) chore(release): Bump to version 0.4.2 (#5964)

'main' bucket:
230382788 (HEAD -> master, origin/master, origin/HEAD) osquery: Update to version 5.12.2

'extras' bucket:
7df7fa13b (HEAD -> master, origin/master, origin/HEAD) qownnotes: Update to version 24.5.6

'sysinternals' bucket:
e669cc0 (HEAD -> main, origin/main, origin/HEAD) chore(ci): switch to `pull_request_target` trigger

'nerd-fonts' bucket:
4b1954d (HEAD -> master, origin/master, origin/HEAD) LXGWNeoXiHei: Update to version 1.122

'java' bucket:
b6305e15 (HEAD -> master, origin/master, origin/HEAD) dragonwell8-jdk: Update to version 8.19.20-8.0.412

'games' bucket:
1c173b687 (HEAD -> master, origin/master, origin/HEAD) unciv: Update to version 4.11.14

Scoop Config

last_update           : 21/05/2024 18:25:49
aria2-warning-enabled : False
aria2-disabled        : True
scoop_repo            : https://github.com/ScoopInstaller/Scoop
scoop_branch          : master

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.2
PSEdition                      Core
GitCommitId                    7.4.2
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

bourbonbourbon commented 4 months ago

There is something going on with the Browser\browser (current\browser missing) directory. I simply copy that from the archive file and then the browser works just fine.

cacophobe commented 3 months ago

I can confirm, this is an issue. Started after update to version 13.0.15 for me. I installed it manually (without scoop) to confirm that it works fine by itself.

This may or may not be related, but in case it helps, I noticed a new executable called lyrebird.exe in INSTALL_FOLDER\browser\torbrowser\tor\pluggabletransports\lyrebird.exe that needed internet access.

bourbonbourbon commented 3 months ago

@cacophobe That is interesting, do you see a current/browser folder? Because for me scoop is not extracting it correctly, it extracts the contents of Browser/browser and then overwrites it with the contents of Browser excluding Browser/browser. I tried downgrading but I still see the same error. I think scoop itself was updated and how it is behaving weird?

Do you see the browser GUI? Because I do not.

bourbonbourbon commented 3 months ago

The release of scoop version 0.4.2 coincides with release of tor 13.0.15. https://github.com/ScoopInstaller/Extras/blob/master/bucket/tor-browser.json https://github.com/ScoopInstaller/Scoop/releases

So probably a bug in scoop itself and not with tor or this bucket.

otavio-silva commented 3 months ago

There is something going on with the Browser\browser (current\browser missing) directory. I simply copy that from the archive file and then the browser works just fine.

Can confirm that copying the missing folder fixes the issue, just tested it in version 13.0.16. Will report the issue on Scoop, since it may be a problem with the extracting process.

basketshoe commented 1 month ago

Still broken :(

o-l-a-v commented 1 month ago

Next release of Scoop with https://github.com/ScoopInstaller/Scoop/pull/6092 should fix it.

basketshoe commented 1 month ago

Awesome! Thanks for the quick reply @o-l-a-v 🙇🏻‍♂️