[Bug]: DBeaver update to 24.1.3 fails

shaulroyzen commented 2 months ago

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

DBeaver

Expected/Current Behaviour

Update succeeds

Steps to Reproduce

`scoop update dbeaver`

Updating one outdated app:
Updating 'DBeaver' (24.1.2 -> 24.1.3)
Downloading new version
Loading dbeaver-ce-24.1.3-win32.win32.x86_64.zip from cache
Checking hash of dbeaver-ce-24.1.3-win32.win32.x86_64.zip ... ok.
Uninstalling 'DBeaver' (24.1.2)
Removing shim 'dbeaver.shim'.
Removing shim 'dbeaver.exe'.
Removing shim 'dbeaver-cli.shim'.
Removing shim 'dbeaver-cli.exe'.
Unlinking ~\scoop\apps\DBeaver\current
Installing 'DBeaver' (24.1.3) [64bit] from 'extras' bucket
Loading dbeaver-ce-24.1.3-win32.win32.x86_64.zip from cache
Extracting dbeaver-ce-24.1.3-win32.win32.x86_64.zip ... Exception: C:\Users\ShaulRoyzen\scoop\apps\scoop\current\lib\core.ps1:889
Line |
 889 |          throw "Could not find '$(fname $from)'! (error $($proc.ExitCo …
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Could not find 'dbeaver'! (error 11)

Possible Solution

None

Scoop and Buckets Version

Current Scoop version:
be56faf2 (HEAD -> master, tag: v0.5.1, origin/master, origin/HEAD) chore(release): Bump to version 0.5.1 (#6057)

'main' bucket:
b2f979201 (HEAD -> master, origin/master, origin/HEAD) nu: Update to version 0.96.0

'extras' bucket:
b7e4af2b0 (HEAD -> master, origin/master, origin/HEAD) twinkle-tray: Update to version 1.15.5

'versions' bucket:
2f1eff09c (HEAD -> master, origin/master, origin/HEAD) neovim-nightly@0.11.0-486: Fix hash (Closes #1864)

'sysinternals' bucket:
6b2b695 (HEAD -> main, origin/main, origin/HEAD) sysmon: Update to version 15.15

'java' bucket:
7ba2d33f (HEAD -> master, origin/master, origin/HEAD) zulufx21-jre: Update to version 21.36.17

Scoop Config

last_update        use_lessmsi scoop_branch scoop_repo
-----------        ----------- ------------ ----------
24-Jul-24 10:14:29        True master       https://github.com/ScoopInstaller/Scoop

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.22621.3880
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.3880
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

No response

aliesbelik commented 2 months ago

Not reproducible for the same upgrade case:

λ scoop update dbeaver
dbeaver: 24.1.2 -> 24.1.3
Updating one outdated app:
Updating 'dbeaver' (24.1.2 -> 24.1.3)
Downloading new version
Loading dbeaver-ce-24.1.3-win32.win32.x86_64.zip from cache.
Checking hash of dbeaver-ce-24.1.3-win32.win32.x86_64.zip ... ok.
Uninstalling 'dbeaver' (24.1.2)
Removing shim 'dbeaver.shim'.
Removing shim 'dbeaver.exe'.
Removing shim 'dbeaver-cli.shim'.
Removing shim 'dbeaver-cli.exe'.
Unlinking ~\scoop\apps\dbeaver\current
Installing 'dbeaver' (24.1.3) [64bit] from 'extras' bucket
Loading dbeaver-ce-24.1.3-win32.win32.x86_64.zip from cache.
Extracting dbeaver-ce-24.1.3-win32.win32.x86_64.zip ... done.
Linking ~\scoop\apps\dbeaver\current => ~\scoop\apps\dbeaver\24.1.3
Creating shim for 'dbeaver'.
Making C:\Users\scoop\scoop\shims\dbeaver.exe a GUI binary.
Creating shim for 'dbeaver-cli'.
Creating shortcut for DBeaver (dbeaver.exe)
'dbeaver' (24.1.3) was installed successfully!

Depending on the antivirus software you are using and its settings it could block installation or quarantine downloaded binary in case of threat detection. Please ensure first that it's not your case.

shaulroyzen commented 2 months ago

Thanks @aliesbelik, I indeed see that on another machine I'm able to install newest DBeaver. I'm having same issue on this machine with the packages temurin-jre and temurin8-jre.

What can I check or try? Didn't find any block in Windows Defender. What exactly this error means? Which directory scoop tries to move and where?

gentius commented 1 month ago

I had the same, but didn't report it here, as sometimes I just skip an update when I run into similar errors.

Now the update scenario is 24.1.2 -> 24.1.5, but I still get the same error.

rahil627 commented 1 month ago

Depending on the antivirus software you are using and its settings it could block installation or quarantine downloaded binary in case of threat detection. Please ensure first that it's not your case.

i found this issue trouble-shooting the same error but for a different package (wezterm). I read that wezterm is simply "unsigned" because the process is stupidly difficult, and so it is often a false-positive. This was indeed my case with BitDefender:

The file C:\Users\ra\scoop\apps\wezterm\20240203-110809-5046fc22\WezTerm-windows-20240203-110809-5046fc22\strip-ansi-escapes.exe is infected with Trojan.GenericKD.72954712 and was moved to quarantine. ...

the error looks like it simply can't find the file, so it makes sense in my case..

may can move this issue to a more general non-package-specific bug/error?

also, it may be nice to catch this error and warn: "file magically disappeared! maybe your anti-virus software didn't like it. >:|"

(just posting info, in case other people run into this.. scoop is god-sent)

update: hmmm, even with the anti-virus turned off temporarily, 7-zip ran into this error!:

ERROR: Cannot open output file : Access is denied. : > C:\Users\ra\scoop\apps\wezterm\20240203-110809-5046fc22\WezTerm-windows-20240203-110809-5046fc22\strip-ansi-escapes.exe

i just had to manually download and install the nightly build, which was recommended by it's maintainer (wez)... will have to figure out how to really turn off the anti-virus sometime later to install it via a package manager

ScoopInstaller / Extras