search

ScoopInstaller / Extras

📦 The Extras bucket for Scoop.
https://scoop.sh
The Unlicense
1.79k stars 1.34k forks source link

Replace google-chrome series broken installer #7096

Closed Lutra-Fs closed 2 years ago

Lutra-Fs commented 2 years ago

Opened as @rashil2000 requested. The affiliated pull request is #7238 now,

HUMORCE commented 2 years ago

i think this is a temporary solution for chrome.

without considering the history versions, we can use the official API to get the latest version infomation.

issaclin32 commented 2 years ago

I vote up for adopting @Lutra-Fs 's solution.

This may bring some issues. But it is better than an obviously broken one.

End-users will not give a * about what is going on. They will just either (1) install from another bucket that is working (2) install with other means such as the installer, Chocolatey or WinGet.

We can consider switching to Chrome's official API later, or make our own version if needed.

Another option is to involve @Lutra-Fs 's repo as an affiliation of Scoop, such as the case of games bucket, nerd-fonts bucket or Java bucket (previously a repo of se35710). Just need to add a few maintainers from Scoop as collaborators.

Lutra-Fs commented 2 years ago

Another option is to involve @Lutra-Fs 's repo as an affiliation of Scoop, such as the case of games bucket, nerd-fonts bucket or Java bucket (previously a repo of se35710). Just need to add a few maintainers from Scoop as collaborators.

If there is anything I can help with, just ping me. My repo is a fork of Sukka (the original API provider) one with the fix of the problem. It is not a scoop bucket. If the repo needs to be a scoop bucket, we will need to add the relevant part.

issaclin32 commented 2 years ago

If the repo needs to be a scoop bucket, we will need to add the relevant part.

Thank you for your great help. The repo does not have to become a bucket. I just want our maintainers to have write access, so that we can fix the problem sooner in the future (even when you are busy).

Lutra-Fs commented 2 years ago

If the repo needs to be a scoop bucket, we will need to add the relevant part.

Thank you for your great help. The repo does not have to become a bucket. I just want our maintainers to have write access, so that we can fix the problem sooner in the future (even when you are busy).

Who should be added as a collaborator？I can do it now.

issaclin32 commented 2 years ago

Who should be added as a collaborator？I can do it now.

I would suggest the following: @rasa @niheaven -- They are early members of Scoop. They may not respond quickly but are more experienced. @stevehipwell @rashil2000 @pratikpc @issaclin32 -- Currently most active members

pratikpc commented 2 years ago

Can we not use https://chromeenterprise.google/browser/download/#windows-tab?

Why do we need to use 3rd party sites?

Using the official sites is just safer tbh

Jogai commented 2 years ago

This site has an api too: https://chromium.woolyss.com/#api

Its 3rd party too, but its been around for a while.

stevehipwell commented 2 years ago

Thanks @Lutra-Fs for the collaboration invite, I'd be happy to help out if this is the approach we're taking.

rashil2000 commented 2 years ago

Can we not use https://chromeenterprise.google/browser/download/#windows-tab?

Why do we need to use 3rd party sites?

Using the official sites is just safer tbh

I think this is only for stable channel. What about beta, canary, dev etc.?

pratikpc commented 2 years ago

@Jogai I also notice that the API is being used by chromium-dev.

It currently states 91.0.4467.0-r869045 as the latest version which isn't exactly true

Is the API reliable? If it is, can you help create a PR to fix the Chrome issue?

Also @Jogai that looks like a primarily Chromium based API. I can't find much regarding Chrome support.

What about beta, canary, dev etc.?

@rashil2000 we could first start somewhere. For the time being use 3rd party libraries and then move on to more stable and official solutions.

pratikpc commented 2 years ago

@rashil2000 if we end up using this solution, given this time it is running on GitHub Actions itself, should we fork it as well and bring it under the Scoop organisation?

@Lutra-Fs is well versed with the codebase so @Lutra-Fs probably takes over as primary maintainer in case of future changes being required

We could also check out VersionHistory API once to help implement future changes as well

rashil2000 commented 2 years ago

We can have a generic repository for services like these - creating a separate repo for each app-group (chrome in this case) would not make sense.

pratikpc commented 2 years ago

@rashil2000 should we start with google-chrome?

rashil2000 commented 2 years ago

We can have a folder within that repo called google-chrome. But what will we name the repo?

issaclin32 commented 2 years ago

We can have a folder within that repo called google-chrome. But what will we name the repo?

How about UpdateTracker? It is a bland name, but we can change it later (possibly after the scoop->scooper issue is resolved)

pratikpc commented 2 years ago

@issaclin32 I like the name

I think we should create the repo though now.

Been a while since Chrome last received an update