search

ScoopInstaller / Extras

📦 The Extras bucket for Scoop.
https://scoop.sh
The Unlicense
1.78k stars 1.33k forks source link

[Request] SDL2 #7867

Open criticic opened 2 years ago

criticic commented 2 years ago

Sort of Master Post related to SDL

Package Request

SDL2 (Base library)

https://www.libsdl.org/download-2.0.php

SDL_image (image)

https://www.libsdl.org/projects/SDL_image

SDL_ttf (font)

https://github.com/libsdl-org/SDL_ttf

SDL_mixer (sound)

https://www.libsdl.org/projects/SDL_mixer/

Bug fix

Currently the entire source code is downloaded, but we only need the package config file. So it would make sense to somehow just get the package config(eg. https://raw.githubusercontent.com/libsdl-org/SDL/main/sdl2.pc.in)

Some indication of popularity/repute: [GitHub stars/software reviews etc.] https://www.wikiwand.com/en/List_of_games_using_SDL https://itch.io/games/made-with-sdl

rashil2000 commented 2 years ago

Related https://github.com/ScoopInstaller/Extras/pull/4259

criticic commented 2 years ago

@rashil2000 how exactly should the mingw packages be added? Would making them available to pkg-config suffice? Does it need to be added to its own /bin /lib etc ?

rashil2000 commented 2 years ago

Sorry, I have no idea about this software, I won't be able to help :(

(I trust the contributors who are familiar with it when they submit the manifest).

tresf commented 2 years ago

Would making them available to pkg-config suffice?

In short, yes, exposing to pkg-config is enough. If scoop has since added a standardized way to do this, great. At the time of the originating PR, none existed, so a global environment variable was used which pkg-config will pick up.

Of course, there are other ways the library can be found (e.g. FindSDL2.cmake) but this comes with its own drama ❤️ and is probably best for another repo. :)

Does it need to be added to its own /bin /lib etc ?

Not necessarily, as long as it can be found.

rongcuid commented 1 year ago

For whatever reason, pkg-config does not work even though the envs are set.

tresf commented 1 year ago

For whatever reason, pkg-config does not work even though the envs are set.

As long as pkg-config honors that variable, it should work. My only recommendation is to echo its value just before use and ensure the path separators are valid for your operating system.