search

ScoopInstaller / GithubActions

Github Actions for Scoop buckets
MIT License
24 stars 22 forks source link

Push hash-fix instead of making a PR #1

Closed rashil2000 closed 2 years ago

rashil2000 commented 2 years ago

Will save a good amount of time :)

Tested here - https://github.com/rashil2000/Extras/commits/master

Issues got closed automatically - https://github.com/rashil2000/Extras/issues?q=is%3Aissue+is%3Aclosed

issaclin32 commented 2 years ago

Thumbs up for this improvement.

IMO, It would be better to add an extra check for file sizes, e.g. The file should not be less than 100KB, to avoid corrupted files when the link is invalid redirected to a web page.

rashil2000 commented 2 years ago

It would be better to add an extra check for file sizes, e.g. The file should not be less than 100KB, to avoid corrupted files when the link is invalid redirected to a web page.

I don't quite get it, which files?

issaclin32 commented 2 years ago

I mean the archive/installer in manifest's url.

Sometimes the developer of the software changes the file url, which causes the page to be redirected to a 404 page, homepage or something else. This will obviously cause installation to fail if we straight up corrects the hash.

rashil2000 commented 2 years ago

Sometimes the developer of the software changes the file url, which causes the page to be redirected to a 404 page, homepage or something else. This will obviously cause installation to fail if we straight up corrects the hash.

Have we seen such a case? It will be better to discuss this in an issue here - since it's not directly related to this PR.

I was under the impression that Scoop will not download/throw an error if it detects a 404, to prevent downloading a webpage.