search

ScoopInstaller / GithubActions

Github Actions for Scoop buckets
MIT License
24 stars 22 forks source link

[Bug] Github Action Excavator auto update is not using the right version from checkver #3

Closed LazyGeniusMan closed 2 years ago

LazyGeniusMan commented 2 years ago

Bug Report

Current Behavior

Detected version from checkver is not used in auto update

Expected Behavior

Detected version from checkver is used in auto update

Additional context/output

For example, mindforger detected checkver is 1.53.0^1 but in auto update the version is 1.1.1^2, this also happen in other excavator run^3.

It's also happen in other manifest, for example: ldplayer^4, kate^5, mqttx^6 and many others.

Is this bug? I tried to locally run checkver for mqttx and it's updated correctly.

Possible Solution

I haven't found yet what's exactly wrong but looks like excavator is using auto-pr.ps1 maybe there is something wrong there since checkver.ps1 is working? but some manifest is updated correctly tho.

rashil2000 commented 2 years ago

Yes, we have noticed this too. From my observation, nothing is wrong with either auto-pr.ps1 or checkver.ps1. All version fetching logic is inside checkver.ps1, but it seems to be running correctly locally. Also, Main and Versions do not have this issue (yet).

LazyGeniusMan commented 2 years ago

hmm, maybe it's because of variable scope ?, it's all get weird after:

VERBOSE: GET with 0-byte payload
VERBOSE: received 18861-byte response of content type text/html
VERBOSE: GET with 0-byte payload
VERBOSE: received 18800-byte response of content type text/html

I think it's from inkscape checkver. it's using $version variable and the value is 1.1.1 https://github.com/ScoopInstaller/Extras/blob/master/bucket/inkscape.json#L36

maybe try to change that variable with something like $ver $checkver_result, etc?

LazyGeniusMan commented 2 years ago

I think it's from inkscape checkver. it's using $version variable and the value is 1.1.1

Ok so this is the problem. changed it in dummy repo^1, and then run the github action^2, it's working^3.

issaclin32 commented 2 years ago

@issaclin32 can you enable issues for the Actions repo?

Done.

LazyGeniusMan commented 2 years ago

Might also want to change vlc-nightly manifest, iirc it's also use $version variable in the checkver script.

rashil2000 commented 2 years ago

Great, thanks so much for catching this @LazyGeniusMan :)