Closed issaclin32 closed 2 years ago
I think we should really first investigate why the $version variables gets leaked out of the Invoke-Expression call here: https://github.com/ScoopInstaller/Scoop/blob/ac2fb38722fffca9dcea6e7faeda6f305f04ad9b/bin/checkver.ps1#L224, that too in the global scope (because it affects all subsequent checkver calls thereafter).
/cc @niheaven
This is a patch to help us avoid using
$version
in checkver script, which can cause some serious errors like #8494 and #8498.Another way to implement this is through schema.json, but I think implementing this in PR handler is simpler and more readable.