Zulu enhancements - Githubissues

ScoopInstaller / Java

📦 A bucket for Scoop, for Oracle Java, OpenJDK, Eclipse Temurin, IBM Semeru, Zulu, ojdkbuild, Amazon Corretto, BellSoft Liberica, SapMachine and Microsoft JDK.

https://scoop.sh

The Unlicense

263 stars 90 forks source link

Zulu enhancements #515

Closed ryansuhartanto closed 5 months ago

ryansuhartanto commented 6 months ago

Should resolves #514.

[x] I have read the Contributing Guide.

github-actions[bot] commented 6 months ago

Your changes do not pass checks.

microsoft21-jdk

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction

zulu-jdk

[x] Description
[x] License
[x] Hashes
[ ] Checkver
[ ] Autoupdate
[ ] Autoupdate Hash Extraction

zulu-jre

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction

zulufx-jdk

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction

zulufx-jre

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction

ryansuhartanto commented 6 months ago

I'll use this jsonpath to filter the version and product UUIDs

$..['distro_version','package_uuid']

And then I use regex to match it (example: https://regex101.com/r/bYBxsK/1)

\[\s*\[\s*(?<major>\d+),\s*(?<minor>\d+),\s*(?<patch>\d+),\s*\d\s*\],\s*"(?<amd64>[\w-]+)"(?:,\s*\[\s*(?:\d+,?\s*)+\],\s*"(?<i686>[\w-]+)")\s*\]

ryansuhartanto commented 6 months ago

I think I found a bug when doing json_path.

$ json_path '[{"availability_type":"CA","distro_version":[17,48,15,0],"download_url":"https://cdn.azul.com/zulu/bin/zulu17.48.15-ca-fx-jre17.0.10-win_x64.zip","java_version":[17,0,10],"latest":true,"name":"zulu17.48.15-ca-fx-jre17.0.10-win_x64.zip","openjdk_build_number":7,"package_uuid":"cef00b50-77db-400a-afdd-b9e391e44631","product":"zulu"},{"availability_type":"CA","distro_version":[17,48,15,0],"download_url":"https://cdn.azul.com/zulu/bin/zulu17.48.15-ca-fx-jre17.0.10-win_i686.zip","java_version":[17,0,10],"latest":true,"name":"zulu17.48.15-ca-fx-jre17.0.10-win_i686.zip","openjdk_build_number":7,"package_uuid":"25351721-5e7e-4eef-a0ef-0c3686b38631","product":"zulu"}]' "$..['distro_version','package_uuid']" $null $false $false
[
  17,
  48,
  15,
  0
]\ncef00b50-77db-400a-afdd-b9e391e44631\n[
  17,
  48,
  15,
  0
]\n25351721-5e7e-4eef-a0ef-0c3686b38631

ryansuhartanto commented 5 months ago

Product UUIDs is discarded using this technique, but this is the best I can do for the current Scoop version by utilizing include_fields.

eijckron commented 5 months ago

@se35710 You have approved most of the recent PR's. What is needed to get this PR merged?

se35710 commented 5 months ago

@se35710 You have approved most of the recent PR's. What is needed to get this PR merged?

Just a little unsure about the JEP 449 and the removal of x86-32 binaries. Going to merge it now.