search

ScoopInstaller / Main

📦 The default bucket for Scoop.
https://scoop.sh
The Unlicense
1.6k stars 968 forks source link

ngrok autoupdate not working for v3 #3603

Closed jordanbtucker closed 2 years ago

jordanbtucker commented 2 years ago

Bug Report

Package Name: ngrok

Current Behaviour

ngrok v3 is not in the bucket because the autoupdate script does not check the new v3 page.

Expected Behaviour

The autoupdate script should check for v3 and update the manifest.

Additional context/output

ngrok seems to have put its v3 releases at https://dl.equinox.io/ngrok/ngrok-v3/stable/archive instead of https://dl.equinox.io/ngrok/ngrok/stable/archive

Possible Solution

Changing the autoupdate script to look at the new v3 archive will work, but I don't know if ngrok is planning on updating the original archive.

System details

Windows version: 10

OS architecture: 64bit

PowerShell version: 7.2.3

Additional software:

Scoop Configuration

{
  "lastupdate": "2022-05-24T09:00:43.8725175-05:00",
  "SCOOP_REPO": "https://github.com/lukesampson/scoop",
  "SCOOP_BRANCH": "master"
}
tech189 commented 2 years ago

I've got a manifest working for v3. Before I make a PR, do you think it would be good to keep a package for v2 in the Versions bucket?

jordanbtucker commented 2 years ago

I think that would be prudent considering v3 has breaking changes.