ScoopInstaller / Main

📦 The default bucket for Scoop.
https://scoop.sh
The Unlicense
1.6k stars 966 forks source link

[Bug]: youtube-dl package is outdated. new version are built elsewhere. #5557

Open cderv opened 8 months ago

cderv commented 8 months ago

Prerequisites

Package Name

youtube-dl

Expected/Current Behaviour

Latest version found in Main bucket is

> scoop info youtube-dl

Name        : youtube-dl
Description : Download videos from YouTube.com (and a few more sites) using command line.
Version     : 2021.12.17
Bucket      : main
Website     : https://github.com/ytdl-org/youtube-dl
License     : Unlicense
Updated at  : 10/10/2023 15:02:33
Updated by  : nitincodery
Binaries    : youtube-dl.exe
Suggestions : ffmpeg | extras/vcredist2010

This is a really old version, and going to the repo release explains : https://github.com/ytdl-org/youtube-dl/releases

This release is old and has many known issues. See "... commits to master since this release" above.

You almost certainly want the nightly build release, and not this one. The nightly build is created from the master branch of this repo if changes have been committed since the last build. Read about Installation of the nightly build. Major fixes in the nightly build are listed https://github.com/ytdl-org/youtube-dl/issues/30839.

Now the release seems to live in https://github.com/ytdl-org/ytdl-nightly/releases/

I would have expected the download from Scoop to be offering the last version available.

Steps to Reproduce

> scoop info youtube-dl

Name        : youtube-dl
Description : Download videos from YouTube.com (and a few more sites) using command line.
Version     : 2021.12.17
Bucket      : main
Website     : https://github.com/ytdl-org/youtube-dl
License     : Unlicense
Updated at  : 10/10/2023 15:02:33
Updated by  : nitincodery
Binaries    : youtube-dl.exe
Suggestions : ffmpeg | extras/vcredist2010

Possible Solution

I believe that the URL for update should be changed https://github.com/ScoopInstaller/Main/blob/09e77fdbbecdee5aa3d744171d5966a65b6c75c8/bucket/youtube-dl.json#L13-L19

so that the new repo is used

This could also be a new manifest, but I don't see the point of keeping a broken build.

Scoop and Buckets Version

> scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
6b1424cbe (HEAD -> master) vscodium: Update to version 1.86.2.24057

'main' bucket:
a01830fa8 (HEAD -> master) red: Update to version 26feb24

Scoop Config

> scoop config

aria2-enabled last_update         scoop_branch scoop_repo
------------- -----------         ------------ ----------
         True 26/02/2024 09:17:43 master       https://github.com/lukesampson/scoop

PowerShell Version

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.4.1
PSEdition                      Core
GitCommitId                    7.4.1
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

milnak commented 8 months ago

Isn't main/yt-dlp the replacement for youtube-dl? If so, maybe yt-dlp should be removed, or perhaps a note added to the manifest to give a warning?

cderv commented 8 months ago

I wasn't aware of https://github.com/yt-dlp/yt-dlp. thanks.

It seems indeed to be a fork of https://github.com/ytdl-org/youtube-dl. There is no message on the README page of youtube-dl - I just so the one in release page. There are a few commits, but indeed not much activity compare to yt-dlp.

perhaps a note added to the manifest to give a warning

So probably adding a note about main/yt-dlp would be better to redirect toward the more active project with new features. Or at least link the two to make them discoverable easily.