Closed silver886 closed 5 months ago
All changes look good.
Wait for review from human collaborators.
I haven't use old plugins and I'm not sure about that. However, the plugin I used needs to be placed in the new folder and it wouldn't work if be placed in the old directory.
I think we should leave the folder contents as is to avoid any impact to users. The plugin structure seems different between these two plugin systems. Ref. https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/plugins.py#L138-L171
Okay, I see. Isn't yt_dlp_plugins
the new folder name though? Your PR has yt-dlp-plugins
instead (with hyphens not underscores).
It is hyphen. We need to use the one with get_executable_path
to setup as portable plugin folder.
Ref. https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/plugins.py#L69-L80
I'm having this issue and can only manually create the yt-dlp-plugins
directory now. Hopefully this PR will be merged soon.
According to document, there is another path for loading plugins.