search

ScoopInstaller / Main

📦 The default bucket for Scoop.
https://scoop.sh
The Unlicense
1.59k stars 956 forks source link

nodejs-lts: fix checkver and add arm64 version #5657

Closed azrdn closed 6 months ago

azrdn commented 6 months ago

Due to the redesign of the Node.js website, the checkver of the nodejs-lts package is broken, this pull request fixes it, and also adds the arm64 version

github-actions[bot] commented 6 months ago

All changes look good.

Wait for review from human collaborators.

nodejs-lts

azrdn commented 6 months ago

/verify

github-actions[bot] commented 6 months ago

All changes look good.

Wait for review from human collaborators.

nodejs-lts

eteeselink commented 6 months ago

For what it's worth: I'm not sure how to review this, but I tested it by running this:

scoop install https://raw.githubusercontent.com/ScoopInstaller/Main/0f5202c216bf79be81549880c86f33eef1218be9/bucket/nodejs-lts.json

(that's the raw URL of the file in this PR)

and it worked flawlessly on my computer. Thanks!

f-cramer commented 6 months ago

Seeing how long it takes to for those PRs to get merged, we should change the checkver script to instead get the latest version from https://nodejs.org/dist/index.json to no longer be dependent on the layout of nodejs.org. See https://github.com/ScoopInstaller/Nonportable/pull/295 for my PR in the nonportable bucket that does exactly that.

niheaven commented 6 months ago

/verify

github-actions[bot] commented 6 months ago

All changes look good.

Wait for review from human collaborators.

nodejs-lts

nodejs