[Bug]: zstd v1.5.6 fails to install

Kosette commented 4 months ago

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

zstd/main

Expected/Current Behaviour

Installation failed due to a change in the package structure.

I have checked the last three package versions and their structure is different. The structure of the packages as follows:

zstd-v1.5.6-win64.zip latest

__zstd-v1.5.6-win64.zip 
  |__ zstd-v1.5.6-win64.zip (a zip in zip, don't know why)
     |___ zstd-v1.5.6-win64 (folder)
         |__ zstd.exe
         |__ other contents

zstd-v1.5.5-win64.zip

__ zstd-v1.5.5-win64.zip
  |___ zstd-v1.5.5-win64 (folder)
      |__ zstd.exe
      |__ other contents

zstd-v1.5.4-win64.zip

__zstd-v1.5.4-win64.zip (no folder) 
  |__ zstd.exe
  |__ other contents

I don't know if there will be a next time, maybe this issue should be reported to facebook/zstd, but I'm not sure.

Steps to Reproduce

`scoop install zstd` or `scoop update zstd`

Possible Solution

i'm not sure.🤔

Scoop and Buckets Version

v0.3.1

Scoop Config

not related

PowerShell Version

not related

Additional Softwares

No response

Arteiimis commented 4 months ago

same

YDX-2147483647 commented 3 months ago

Similar issues in previous versions:

v1.5.0 #2182 #2183
v1.5.1 #3115
v1.5.2 #3221
v1.5.5 #4630 #4631 #4632

Maybe we should fix zstd instead?

https://github.com/facebook/zstd/commits/dev/.github/workflows/windows-artifacts.yml

Kosette commented 3 months ago

Before this issue been resolved, referencing this manifest to bypass temporarily.

Kosette commented 3 months ago

Closed. Zstd developers have fix it, no more double-zipped. https://github.com/facebook/zstd/issues/4000

ScoopInstaller / Main