ScoopInstaller / Main

📦 The default bucket for Scoop.
https://scoop.sh
The Unlicense
1.58k stars 959 forks source link

go: Fix (un)install warnings #5806

Closed brian6932 closed 4 months ago

brian6932 commented 4 months ago
Updating 'go' (1.22.2 -> 1.22.3)
Downloading new version
Starting download with aria2 ...
Download: 05/07 20:49:22 [WARN] --file-allocation=falloc will use SetFileValidData() API, and aria2 uses uninitialized disk space which may contain confidential data as the download file space. If it is undesirable, --file-allocation=preallocDownload: ). File will be allocated by filling zero, which blocks whole aria2 execution. Run aria2 as an administrator orDownload: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: 07f2c6|OK  |    19MiB/s|~/scoop/cache/go#1.22.3#da5209a.zip
Download: Status Legend:
Download: (OK):download completed.
Checking hash of go1.22.3.windows-amd64.zip ... ok.
Uninstalling 'go' (1.22.2)
Running uninstaller script...
INFO  Removing '~\go\bin' from PATH...
WARN  "remove_from_path" will be deprecated. Please change your code/manifest to use "Remove-Path"
      -> :4:1
Removing ~\go\bin from your path.
Removing shim 'go.shim'.
Removing shim 'go.exe'.
Removing shim 'gofmt.shim'.
Removing shim 'gofmt.exe'.
Unlinking ~\scoop\apps\go\current
Installing 'go' (1.22.3) [64bit] from 'main' bucket
Loading go1.22.3.windows-amd64.zip from cache.
Extracting go1.22.3.windows-amd64.zip ... done.
Running installer script...
INFO  Adding '~\go\bin' to PATH...
WARN  "add_first_in_path" will be deprecated. Please change your code/manifest to use "Add-Path"
      -> :4:1
Adding ~\go\bin to your path.
Linking ~\scoop\apps\go\current => ~\scoop\apps\go\1.22.3
Creating shim for 'go'.
Creating shim for 'gofmt'.
'go' (1.22.3) was installed successfully!
github-actions[bot] commented 4 months ago

All changes look good.

Wait for review from human collaborators.

go

Roemer commented 4 months ago

I'm not sure but that somehow broke it for me. I now get that Add-Path and Remove-Path are not recognized when updating go.

go: 1.22.3 -> 1.22.3
Updating one outdated app:
Updating 'go' (1.22.3 -> 1.22.3)
Downloading new version
Loading go1.22.3.windows-amd64.zip from cache
Checking hash of go1.22.3.windows-amd64.zip ... ok.
Uninstalling 'go' (1.22.3)
Running uninstaller script...
INFO  Removing 'C:\Users\xxx\go\bin' from PATH...
Remove-Path : Die Benennung "Remove-Path" wurde nicht als Name eines Cmdlet, einer Funktion, einer Skriptdatei oder
eines ausführbaren Programms erkannt. Überprüfen Sie die Schreibweise des Namens, oder ob der Pfad korrekt ist (sofern
enthalten), und wiederholen Sie den Vorgang.
In Zeile:4 Zeichen:1
+ Remove-Path "$envgopath\bin" $global
+ ~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Remove-Path:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Removing shim 'go.shim'.
Removing shim 'go.exe'.
Removing shim 'gofmt.shim'.
Removing shim 'gofmt.exe'.
Unlinking C:\appl\scoop\apps\go\current
Installing 'go' (1.22.3) [64bit] from main bucket
Loading go1.22.3.windows-amd64.zip from cache
Extracting go1.22.3.windows-amd64.zip ...
brian6932 commented 4 months ago

@Roemer Can't reproduce, what version of scoop are you on?

Roemer commented 4 months ago

Hmm strange that I am still on 0.3.1. That is probably an issue as I installed scoop in a different directory and with the update to 0.4.0 I now have two scoops: one in the default directory (my user folder) and one in my custom directory.