Open StarsbySea opened 1 week ago
All changes look good.
Wait for review from human collaborators.
All changes look good.
Wait for review from human collaborators.
@niheaven Hi, Please take a look at this PR, thanks.
I haven't tried this but is there any reason why the OllamaSetup.exe
was failing?
I think its something that should be looked at before changing to downloading the .zip instead.
innounp.log says:
Signature detected: Inno Setup Setup Data (6.3.0)
This is not directly supported, but i'll try to unpack it as version 5602
; Version detected: 6300
Critical error: The setup files are corrupted. Please obtain a new copy of the program.
The OllamaSetup.exe installer works fine by itself. It drops the files in the users AppData folder as a non-admin install. The tray app and the server run fine.
Ollama v0.1.41 uses Inno Setup v6.1.0 where as Ollama v0.1.44 uses Inno Setup v6.3.0.
I assume the log is right and the new Inno Setup installer is not supported by innounp.
Scoop uses innounp, latest version is 0.50 and supports upto Inno 6.1.2. which was last updated 2020.12.18 and latest Inno version is 6.3.1 (2024-06-10).
... But since it is not updated in a timely fashion, and so does not support the latest IS most of the time, this program was born.
A bit ironic :p
Looks like innoextract could be an alternative? It already has a merge request to support 6.3.1 Inno Setup
Closes #5908 Closes #5909 Closes #5910 Closes #5911 Closes #5912 Closes #5913 Closes #5915 Closes #5917 Closes #5918