[Bug]: Syncthing is automatically updating itself

leumasme commented 3 weeks ago

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

syncthing

Expected/Current Behaviour

syncthing is automatically updating itself by default, desyncing what is actually installed and what version scoop thinks is installed.

Steps to Reproduce

Just having syncthing open will cause it to check for an update and automatically install it every 12 hours. https://docs.syncthing.net/v1.28.0/users/config#config-option-options.autoupgradeintervalh

Possible Solution

Currently, users can workaround by manually disabling auto updates: Advanced onfiguration -> Options -> Auto Upgrade Interval (hours) = 0 Ideally, this should be set by default when installing syncthing via scoop. It's stored in persist/syncthing/config/config.xml autoUpgradeIntervalH

Scoop and Buckets Version

❯ scoop --version
Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
7bd4c4ac2 (HEAD -> master, origin/master, origin/HEAD) rust-analyzer: Update to version 2024-10-28

'extras' bucket:
727cff531 (HEAD -> master, origin/master, origin/HEAD) ddu@18.0.8.4: Fix hash (Closes #14308)

'versions' bucket:
2c9c47d8f (HEAD -> master, origin/master, origin/HEAD) openscad-dev: Update to version 2024.10.28

'java' bucket:
ef9e6cb6 (HEAD -> master, origin/master, origin/HEAD) openjdk-ea: Update to version 24-21-ea

'games' bucket:
44718a920 (HEAD -> master, origin/master, origin/HEAD) cataclysm-dda-tiles-experimental: Update to version 2024-10-28-0543

'nirsoft-alt' bucket:
c495135 (HEAD -> master, origin/master, origin/HEAD) Create LICENSE

Scoop Config

❯ scoop config

last_update     : 28.10.2024 12:51:17
aria2-enabled   : False
alias           : @{i=scoop-i; ls=scoop-ls; s=scoop-s; up=scoop-up}
cat_style       : grid,numbers
show_update_log : False
scoop_branch    : master
scoop_repo      : https://github.com/lukesampson/scoop

PowerShell Version

❯ $psversiontable

Name                           Value
----                           -----
PSVersion                      7.4.4
PSEdition                      Core
GitCommitId                    7.4.4
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

HUMORCE commented 2 weeks ago

Could you make a PR for the improvement?

leumasme commented 1 week ago

~~The default config.xml isn't directly included in the github release zip so I'm not sure how this should ideally be solved without just hardcoding the whole config.xml into the scoop installer script to be written on install. Maybe a syncthing dev could give advice on this? I might open an issue there.~~

Edit: Nevermind; there is a --no-upgrade CLI argument. I guess it could be added to the shim arguments so it won't update when running via the shim at least? Also there is a STNOUPGRADE environment variable that can be set to block syncthing upgrades. It's syncthing specific (ST prefix = SyncThing), so it could be set globally if no other syncthing installs are on the system? Idk which is the preferred way here.

ScoopInstaller / Main