Add PHP 7.3 and remove checkver from 5.6, 7.0

ScoopInstaller / PHP

📦 PHP Bucket for Scoop

http://scoop.sh

MIT License

43 stars 13 forks source link

Add PHP 7.3 and remove checkver from 5.6, 7.0 #1

Closed niheaven closed 5 years ago

niheaven commented 5 years ago

I don't use PHP with scoop, so just fix checkver.

r15ch13 commented 5 years ago

Please add the checkver back for older versions. They still can get security fixes (even if they are EOL) Older versions are located in https://windows.php.net/downloads/releases/archives/

niheaven commented 5 years ago

Change bucketdir to Find-BucketDirectory
Add suggest according to filename (VC9: vcredist2008, VC11: vcredist2012, VC14, VC15: vcredist2019)
Fix PHP 5.6 and PHP 7.0 url

checkver couldn't work in https://windows.php.net/downloads/releases/archives/, the filename there aren't sorted by datetime, but simple alphabeta order. So for security fixes, the manifests need manually update.

r15ch13 commented 5 years ago

Ping via https://github.com/ScoopInstaller/PHP/issues/2

niheaven commented 5 years ago

This is ready to merge. Old versions' checkver are unrealizable 😭