license property in autoupdate missing in schema.json

se35710 commented 6 years ago

From AppVeyor;

    [*] wlp-javaee.json: Property 'license' has not been defined and the schema does not allow additional properties.
      [-] wlp-javaee.json 144ms
        Expected 0, but got 1.
        186:                         $validator.Errors.Count | should be 0
        at Invoke-LegacyAssertion, C:\Program Files\WindowsPowerShell\Modules\Pester\4.4.0\Functions\Assertions\Should.ps1: line 188
        at <ScriptBlock>, C:\projects\scoop-ibm\Scoop-Bucket.Tests.ps1: line 186

In wlp-javaee.json:

    "autoupdate": {
        "url": "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/$version/wlp-javaee7-$version.zip",
        "license": "https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/downloads/wlp/$version/lafiles/runtime/en.html"
},

During updates, the license property is updated as expected.

hermanjustnu commented 6 years ago

Same issue with shortcuts property:

    [*] desmume.json: Property 'shortcuts' has not been defined and the schema does not allow additional properties.
    [*] desmume.json: Property 'shortcuts' has not been defined and the schema does not allow additional properties.
      [-] desmume.json 105ms
        Expected 0, but got 2.
        186:                         $validator.Errors.Count | should be 0
        at Invoke-LegacyAssertion, C:\Program Files\WindowsPowerShell\Modules\Pester\4.4.0\Functions\Assertions\Should.ps1: line 188
        at <ScriptBlock>, C:\projects\scoop-emulators\Scoop-Bucket.Tests.ps1: line 186

In desmume.json:

        "architecture": {
            "64bit": {
[..]
                "shortcuts": [
                    [
                        "DeSmuME_$version_x64.exe",
                        "DeSmuME"
                    ]
                ]
            },
            "32bit": {
[..]
                "shortcuts": [
                    [
                        "DeSmuME_$version_x86.exe",
                        "DeSmuME"
                    ]
                ]
            }
        },

During updates, the shortcuts properties are updated as expected.

niheaven commented 2 years ago

@se35710 Does license still need to be updated now? The new feature of autoupdate could update nearly everything in manifest, but license is not added to schema.json.

se35710 commented 2 years ago

@niheaven Yes, I know of manifests where the license file requires a version in the URL, so IMHO it should be added to schema.json, and logic for it in Scoop (if not already in place).

ScoopInstaller / Scoop

license property in autoupdate missing in schema.json #2454