search

ScoopInstaller / Scoop

A command-line installer for Windows.
https://scoop.sh
Other
20.51k stars 1.38k forks source link

Scoop is considered installed when zip failed to download #3829

Open jetersen opened 4 years ago

jetersen commented 4 years ago

The install condition for scoop is not good enough as an empty folder is considered as if scoop was installed successfully.

image

Ash258 commented 4 years ago

Duplicate of #3816

scoop list/status will tell you it was failed. Keeping the folder is for debug purpose as there are logs.

as an empty folder is considered as if scoop was installed successfully.

Not true. Successfull installation is considered only if install.json exists in current folder

image

jetersen commented 4 years ago

This is not true when scoop fails to install

When scoop fails to unzip into current, scoop is considered installed and there is no install.json This happens when you try and run the install.ps1 on get.scoop.sh