search

ScoopInstaller / Scoop

A command-line installer for Windows.
https://scoop.sh
Other
20.99k stars 1.4k forks source link

Please be tolerant to weak Internet connection #4279

Open galaxy001 opened 3 years ago

galaxy001 commented 3 years ago

I find scoop have no checking for bad Internet such as Chinese Internet, where about half of all connections can be dropped without any reply.

When install 7zip, if the msi failed to download, scoop will just continue with a null file and create empty folder in apps.

When scoop update, when git hangs in the middle, after stop git, scoop will move incomplete new folder to replace current folder, thus resulting scoop itself not working.

I hope scoop and add some checking for network failure.

HUMORCE commented 3 years ago

related: https://github.com/lukesampson/scoop/issues/4264

galaxy001 commented 3 years ago

I think it is better for scoop to check the downloaded files. It is not good to continue with a file not found warning or with incomplete git repo.

Homebrew is checking every downloaded file with hash.