ScoopInstaller / Scoop

A command-line installer for Windows.
https://scoop.sh
Other
20.95k stars 1.39k forks source link

[useragent] Add a global "useragent" key #5586

Closed AntonOks closed 11 months ago

AntonOks commented 1 year ago

Feature Request

Add a global "useragent" key, which, if defined, overwrites what https://github.com/ScoopInstaller/Scoop/blob/f93028001fbe5c78cc41f59e3814d2ac8e595724/lib/core.ps1#L26 returns

Is your feature request related to a problem? Please describe.

Some websites seem to ban"scoop". One of them is "filezilla-project.org". Sometimes manifests work around this ban and refer to other websites, see also the filezilla manifest. Seems like to address this kind of issue, "checkver" introduces the "useragent" key here . So now one can check if a new version is available based on "scoop banning sites", but still cannot "autoupdate" such manifests.

Describe the solution you'd like

I'd like to see an "useragent" root key in the manifests, which, if defined, overwrites all respective user agents everywhere in the scoop tools and manifests.

Describe alternatives you've considered

I thought about extending "autosupport" in the same way as commit 8feb386 extended "checkver", but then again I'm convinced a general "useragend" key would be the better solution.

AntonOks commented 1 year ago

there is already #5043 ... so if a general "useagent" key would not gonna happen any time soon, could someone please pull #5043 asap?

With the already implemented "checkver", see here . and then the still-to-be-pulled "autoupdate" enhancement #5043 , we would be almost there anyhow, right? :|

HUMORCE commented 1 year ago

A complete custom request headers should be implemented, rather than a part of them, although some sites explictly forbid about this.

For personal/private/enterprise buckets: Scoop can supports more scenes For offical buckets: Avoid use custom request headers for sites forbid it

rashil2000 commented 11 months ago

Tracking this in #4062