[Bug] `warn outdated buckets` always shown when any local bucket used

goyalyashpal commented 4 months ago

Bug Report

Current Behavior

scoop status wrongly shows "bucket(s) out of data" when there are local buckets

Expected Behavior

when all buckets are already up-to-date, no warning is shown.

Additional context/output

edit: better yet; both these commands are run together sequentially using ; but the WARN out of date is still shown.

(earlier i thought to use \t time in PS1 prompt, to show the immediate sequential run)

$ scoop update; scoop status
Updating Scoop...
Updating 'dorado' bucket...
Updating 'extras' bucket...
Updating 'java' bucket...
Updating 'main' bucket...
Updating 'nerd-fonts' bucket...
Updating 'nonportable' bucket...
Updating 'local' bucket...
'local' is not a git repository. Skipped.
Scoop was updated successfully!
WARN  Scoop bucket(s) out of date. Run 'scoop update' to get the latest changes.

Name      Installed Version Latest Version  Missing Dependencies Info
----      ----------------- --------------  -------------------- ----
alacritty 0.13.1            0.13.2

Possible Solution

if scoop can't update local buckets, then it should not consider those to be outdated either

System details

$ systeminfo | grep -iE "^os version|system type"
OS Version:                10.0.19045 N/A Build 19045
System Type:               x64-based PC

$ powershell -c '& {$($PSVersionTable.PSVersion)}'

Major  Minor  Build  Revision
-----  -----  -----  --------
5      1      19041  4170

Scoop Configuration

$ # scoop config
$ cat "$USERPROFILE"/.config/scoop/config.json
{
    "root_path":  "D:\\UserFiles\\scoop",
    "global_path":  "D:\\ProgramFiles\\scoop_global",
    "last_update":  "2024-04-11T11:49:19.8365712+05:30",
    "alias":  {
                  "cat-dum":  "scoop-cat-dum"
              },
    "debug":  true,
    "scoop_branch":  "master",
    "scoop_repo":  "https://github.com/ScoopInstaller/Scoop"
}

niheaven commented 4 months ago

Aha, thank you for investigating the features of Scoop. There seem to be several bugs, which we will fix after the looooooong-awaited version #5424.

goyalyashpal commented 4 months ago

after the looooooong-awaited version #5424

what's blocking that?

goyalyashpal commented 4 months ago

one workaround hack can be to not use any directory. rather, put the manifests at root of the ...\scoop\buckets\

so, do

buckets/app1.json
buckets/app2.json

instead of:

buckets/local/app1.json
buckets/local/app2.json

ScoopInstaller / Scoop