ScoopInstaller / Versions

📦 A Scoop bucket for alternative versions of apps.
https://scoop.sh
The Unlicense
207 stars 199 forks source link

[Bug]: prismlauncher-git wrong major and monir version due to it being hardcoded in the script #1960

Open sokripon opened 1 week ago

sokripon commented 1 week ago

Prerequisites

Package Name

prismlauncher-git

Expected/Current Behaviour

The current manifest for prismlauncher-git has uses hardcoded 7.0 as the version number + the commit hash. This results in the version being wrong for versions that are not 7.0

Steps to Reproduce

❯ scoop update prismlauncher-git
prismlauncher-git: 7.0-a634512 (latest version)
Latest versions for all apps are installed! For more information try 'scoop status'

Possible Solution

Creating a more complex checkver check.

Scoop and Buckets Version

❯ scoop --version
Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
fbd80966c (HEAD -> master, origin/master, origin/HEAD) slang: Update to version 2024.13

'extras' bucket:
e4f03398a (HEAD -> master, origin/master, origin/HEAD) skype: Update to version 8.129.0.202

'versions' bucket:
25f6ec97b (HEAD -> master, origin/master, origin/HEAD) zettlr-nightly: Update to version 3.2.1-20240930

Scoop Config

❯ scoop config

last_update         virustotal_api_key                                               scoop_repo                              scoop_branch
-----------         ------------------                                               ----------                              ------------
30/09/2024 15:43:00 xxxxxxxxxxxxxxxxxx https://github.com/ScoopInstaller/Scoop master

PowerShell Version

❯ $PSVersionTable 

Name                           Value                                                                                                                                                                                     
----                           -----                                                                                                                                                                                     
PSVersion                      7.4.2                                                                                                                                                                                     
PSEdition                      Core                                                                                                                                                                                      
GitCommitId                    7.4.2                                                                                                                                                                                     
OS                             Microsoft Windows 10.0.22635                                                                                                                                                              
Platform                       Win32NT                                                                                                                                                                                   
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}                                                                                                                                                                     
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

sokripon commented 1 week ago

Working on it