ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
77 stars 19 forks source link

Toggle for filtering results from known buckets #1

Closed rashil2000 closed 2 years ago

rashil2000 commented 2 years ago

Hi!

I'm here from https://github.com/ScoopInstaller/Scoop/issues/4627#issuecomment-1012173950, and I wanted to ask whether a toggle/checkbox that could be added to only show search results from known buckets, somewhere in the middle here:

image

(I'm aware that the results are already sorted to show known buckets first, but still.)

Cheers!

gpailler commented 2 years ago

Hey @rashil2000 ,

Thanks for your request. The information about the bucket source type is already stored in the index so it should be quite straight-forward. I will try to take a look and add this toggle.

rashil2000 commented 2 years ago

Thanks for the update! Looking forward to it :)

gpailler commented 2 years ago

I just pushed a new version with a toggle to search only in the official buckets image

I'm open to your suggestions as I'm not fully happy with the placement/wording.

rashil2000 commented 2 years ago

Hmm, I have a couple of thoughts:

gpailler commented 2 years ago

I tried to put the switch in the center but it doesn't look nice and is too distractive. I ended up with a placement on the right with your label and it looks way better.

image

What are your thoughts?

rashil2000 commented 2 years ago

To me it looks asymmetrical (sparse on left and congested on right). But if there's no other way, it's understandable.

gpailler commented 2 years ago

Yep, I prefer to keep the sorting/filtering options in the same area even if it makes the display slightly asymmetrical. It doesn't look too disturbing to me 👍

rashil2000 commented 2 years ago

No worries, thanks for the quick turnaround on implementing this request ❤️

Should I close this?

gpailler commented 2 years ago

You're welcome! I let you close this request...