search

ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
83 stars 18 forks source link

Wrong `scoop bucket add` command suggested for `games`, `nirsoft`, `nerd-fonts` and `nonportable` #15

Closed JanPokorny closed 2 years ago

JanPokorny commented 2 years ago

The suggested command in the UI for nirsoft is scoop bucket add scoop-nirsoft, which sadly does not work due to the extra prefix. Same happens with games, nerd-fonts and nonportable. Looks like ScoopSearch assumes that the bucket is "known" in Scoop under the same name as the repository name.

obrazek

rashil2000 commented 2 years ago

This file should be used as the single source of truth for known buckets and their shorthands/aliases - https://github.com/ScoopInstaller/Scoop/blob/master/buckets.json

gpailler commented 2 years ago

Thanks for the feedback. You are perfectly right; the bucket name is using the repository name and it's incorrect for some known repos. Will fix it 👍

gpailler commented 2 years ago

Done! Could you double check on https://scoopsearch.github.io/scoopsearch-dev.github.io then I will merge to master

rashil2000 commented 2 years ago

It needs to be changed in 2 more places:

  1. image image

and here:

  1. image

JanPokorny commented 2 years ago

@rashil2000 The second screenshot seems correct to me, it shows repository names, the problem is only when adding the bucket. I agree that the name in the title should be unprefixed though.

gpailler commented 2 years ago

The repository name is updated in the results for official buckets

rashil2000 commented 2 years ago

LGTM!