ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
77 stars 19 forks source link

Dark mode #20

Closed rollingmoai closed 2 years ago

rollingmoai commented 2 years ago

Dark mode for users who don't want to burn their eyes. I hope this isn't too hard to implement.

gpailler commented 2 years ago

It's a great idea! I will try to find a way to implement this dark mode

gpailler commented 2 years ago

@itsmeboy0 Dark mode is available on https://scoopsearch.github.io/scoopsearch-dev.github.io/ for testing. Dark mode is used automatically according to the the browser/os configuration.

rollingmoai commented 2 years ago

Thanks, that looks better. It's usable for me now 🥳 Maybe a toggle for it would be nice?

gpailler commented 2 years ago

Yep, I will check for a trigger but I will have to investigate a bit deeper as there is no builtin support for theme switching

gpailler commented 2 years ago

@itsmeboy0 I added a button to force dark or light mode. Please have a look on https://scoopsearch.github.io/scoopsearch-dev.github.io/

rollingmoai commented 2 years ago

Weird, three buttons, unlike most websites (ex. https://spicetify.app/, dark and light mode toggle only, default to system config, remember choice).

gpailler commented 2 years ago

Yep, the third state is used to reset to auto mode (browser/os choice). I can remove it if you think it's too much

rollingmoai commented 2 years ago

Up to you, for me, I'd like the UX to be consistent with that of other websites.

gpailler commented 2 years ago

Ok thanks for your feedback. Let's keep the 3 states for now. I just pushed another change to improve the tooltips and properly switch from auto to the appropriate mode (if auto is light, then switch to dark...)

rashil2000 commented 2 years ago

Implemented in #22