ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
77 stars 19 forks source link

Opinion: "Official buckets only" filter should be on by default #26

Closed mertd closed 2 years ago

mertd commented 2 years ago

Hi! Congratulations on getting the new scoop.sh website and search online. Looks great!

Since this is the official scoop web search now, I think the "Official buckets only" filter should be on by default. Displaying additional buckets is great for advanced users. For new users of Scoop or package managers in general, however, it introduces additional complexity and may even leave their systems vulnerable because they installed code from weakly moderated buckets.

What do you think? @gpailler @rashil2000

rashil2000 commented 2 years ago

That's something I have considered before (I personally prefer it), but a big disadvantage would be that it will hamper discoverability: most users might never get to know that there are community buckets out there too.

gpailler commented 2 years ago

Yes, I remember it was heavily discussed 😉 I personally think it's one of the strength of Scoop to propose community/unofficial buckets and it would be a pity to hide them by default. One improvement could be to make this filter more discoverable (not hidden in the Sorting/Filtering menu) but we were not able to find the right spot. We tried different positions but it was always making the web page "unbalanced" and the result was not very nice. New ideas are welcome though !

When using the "Best match" sorting (the default one), the results from official buckets/popular community buckets are returned first so I'm not sure it's really disturbing for the users. We are supposed to always propose "safe" results first.

rashil2000 commented 2 years ago

One idea that was discussed in the original issue #1 was to put the toggle in center below the search bar, with the text "Search only known buckets" and the toggle enabled by default. It does look distracting as @gpailler mentioned but it also lets users know that there are other buckets too. I really prefer this approach (I'm biased as a maintainer) because it lets me toggle easily when I'm reviewing and accepting new packages in official buckets. The sorting drop down remains in the side (I've personally never used it as the default sorting is really good).

mertd commented 2 years ago

I agree that the toggle should be more prominent once turned off as a default. I personally actually like the direction of what seems to have been the first design iteration. At the same time, the current state does look more polished.

What do you think about displaying the current sort and filter settings on the button label? E.g. "Official buckets only" and "All buckets", or "Community buckets excluded" and "Community buckets included".

Examples:

grafik

grafik

This would highlight the option to display more buckets to users once showing only the official ones as default. Saving these settings in local storage may also be of help to users who want the community buckets included.

mertd commented 2 years ago

Another option could be to leave the default as-is, but overlay the installation command fields. The overlay could be a message briefly explaining the benefits and risks of community buckets. Alternatively, the actual text could be in a modal and the overlay could just contain a "Display instructions" button. Once dismissed via a button that says something along the lines of "I understand, do not warn me again", the display state could be stored to local storage.

This would allow displaying all buckets as standard, but require more time to implement and may disturb the current polish of the design. Therefore, I prefer the suggestion above.

gpailler commented 2 years ago

Hello @mertd, It's a great idea to use the dropdown title to display the current sort and filter! On https://scoop.sh/scoopinstaller-dev.github.io/#/apps, you will find this idea implemented:

(I'm still not 100% convinced that we should filter out the community buckets by default. ~18500 apps is more appealing than ~4200 for a first time user, even if we have duplicates)

What are your thoughts?

mertd commented 2 years ago

@gpailler This version looks great!

I believe that scoop has its own place due to a few unique qualities rather than app count. That being said, I understand your concern of appealing to first-time users. How do you feel about always showing both the current result count as well as the total number of apps?

Examples:

grafik

grafik

gpailler commented 2 years ago

@rashil2000 do you like the new version too? I can create the PR to merge to main. @mertd Honestly, it's just my personal feeling and maybe ~4200 apps is appealing enough for the first time users 😄. Moreover, as you said, Scoop has other qualities.

We can keep the official buckets filter on by default and wait to see if we get any feedback from first-time users.

rashil2000 commented 2 years ago

Yes, looks good to me!