ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
77 stars 19 forks source link

Unable to search manifest with @ character #32

Closed so1ve closed 2 years ago

so1ve commented 2 years ago

I created a scoop bucket called destiny_versions. It contains the historical versions of all the manifests in the destiny bucket. In order to distinguish it from other manifests, I added a special symbol "@" to the names of these manifests. However, the search engine does not seem to be able to search the manifest that includes these symbols.

so1ve commented 2 years ago

If the search content does not contain @, it can be searched. If @ was added, a lot of extraneous stuff would appear and the manifest that was supposed to appear would disappear.

so1ve commented 2 years ago

For example search: dvm@1. dvm@1.8.2 in so1ve/destiny_versions should appear

rashil2000 commented 2 years ago

If you're the bucket maintainer, I'd strongly suggest not using characters like @, /, \ for manifest names. These characters hold special meaning for Scoop and can unexpectedly break stuff.

so1ve commented 2 years ago

Hmmmm.... Can I use #?

rashil2000 commented 2 years ago

You could try that, for reference see the following regex that captures package names:

https://github.com/ScoopInstaller/Scoop/blob/80b52e32a11fda2089949aaec00295d6185da3f7/lib/core.ps1#L953

so1ve commented 2 years ago

Thanks!

so1ve commented 2 years ago

I have deleted this bucket...I thought scoop didn't have the ability to install historical versions, I was wrong.