Add OpenSearch functionality

ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine

https://scoop.sh

MIT License

81 stars 18 forks source link

Add OpenSearch functionality #35

Closed oneminch closed 2 years ago

oneminch commented 2 years ago

Add OpenSearch functionality so that Scoop.sh can be added as a search engine to browsers.

scoop-screenshot

rashil2000 commented 2 years ago

Hmm, this looks interesting, but why is package-lock.json changed?

oneminch commented 2 years ago

I ran npm update as per the README. It's the result of that command.

rashil2000 commented 2 years ago

Those changes are not required here, so you should remove them

oneminch commented 2 years ago

I think I have undone those changes to package-lock.json.

gpailler commented 2 years ago

LGTM, Thanks!

rashil2000 commented 2 years ago

Just a small question: how do you make use of this in Chromium-based browsers?

oneminch commented 2 years ago

🤔 It was supposed to work according to this: Tab to Search. I've tested it on several Chromium-based browsers.

In Ungoogled Chromium, the ability to add a search engine is disabled in the flags (chrome://flags/#disable-search-engine-collection). But enabling it doesn't have any impact.
In Edge and Brave, the flag doesn't even exist.

From what I've read, in Chromium-based browsers, unlike Firefox-based ones, the user didn't have to add search engines manually. If the site had the OpenSearch description, it was added to the search engines list automatically. I'm guessing that became annoying to a lot of users and they've removed support since.

More information: OpenSearch description format

rashil2000 commented 2 years ago

If the site had the OpenSearch description, it was added to the search engines list automatically.

I think this still happens. Whenever I visit such a website, Edge adds a search engine in its list automatically. But it didn't do that for the site in this PR, which is why I had to ask.

oneminch commented 2 years ago

I tried to add other websites with OpenSearch plugin (like Sourcegraph and NPM) as a search engine, and none of them were added to the Chromium-based browsers. It's definitely weird, or I'm just missing something. There isn't extensive documentation on the matter, either.

rashil2000 commented 2 years ago

What I have observed is that there seems to be a limit on the number of search engines that Edge can save. I remember having to delete some of them to add a custom engine some time ago.

oneminch commented 2 years ago

I only have just one search engine in the list of these browsers since none is my default browser. It's still the same.

gpailler commented 2 years ago

We deployed a fix for the open search functionally #37 and now, the search engine is properly added (tested on Edge on my side) Could you visit https://scoop.sh/ again and check on your side?

Thanks

oneminch commented 2 years ago

It's now working on both Edge and Firefox. Thank you.