search

ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
78 stars 18 forks source link

use vite instead of cra #45

Closed unworthyEnzyme closed 1 year ago

unworthyEnzyme commented 1 year ago

vite still uses babel for the dev so first build, although faster than cra, can still feel slow. There is a new plugin @vitejs/plugin-react-swc for dev but it doesn't yet support decorators, i can open a new pr when it does.

gpailler commented 1 year ago

Thanks for the PR and all the hard work! I tested locally and it works fine (and is much faster locally and on the CI indeed!). I just applied some additional changes/fixes.

If everything looks good to you, I think we can merge this PR.

unworthyEnzyme commented 1 year ago

@gpailler no problem, i'm happy this PR was useful. Everthing looks good i think you can merge it.