search

ScoopInstaller / scoopinstaller.github.io

ScoopInstaller homepage and search engine
https://scoop.sh
MIT License
78 stars 18 forks source link

Possible to have a detail page for apps? #47

Closed KyleMit closed 1 year ago

KyleMit commented 1 year ago

If I'm looking to link someone to the app, it'd be helpful to have a route that takes in the app id.

For example, if I search 7zip like this:

https://scoop.sh/#/apps?s=0&d=1&o=true&q=7zip

I get several results:

image

But if I want to share the url with someone, they have to decipher which version I meant.

Is it possible to direct link to a specific app? There are several links in each card to the main website, the licence, the commit, and the release version, but they all take me off the scoop website. But I couldn't find a way to click to load a single app, similar to how npm handles this:

Search: https://www.npmjs.com/search?q=7zip
Detail: https://www.npmjs.com/package/7zip

rashil2000 commented 1 year ago

A details page doesn't make much sense here, what information will it hold? Especially when the version link will take you to the manifest which contains all information about the package there is.

gpailler commented 1 year ago

As @rashil2000 said, we are displaying already as much as we can in the search results. In the NPM example, they have much more info to display like the number of download/issues/dependencies...

But being able to share a link for a specific application could makes sense. I will try to draft something and make a proposal

gpailler commented 1 year ago

What are your thoughts about this proposal? When you click on the app name, a modal dialog is displayed with the app details and the app id is added to the query string. When the app id is found in the query string, the modal dialog is displayed with the app details

HHZu6aSYrV

KyleMit commented 1 year ago

That UI looks great, and I really like the deeplink ability. Does the id being used in the URL persist over time?

gpailler commented 1 year ago

Yes the id is supposed to be stable. It's a hash of the manifest location in the form : repository + branch + manifest path.

gpailler commented 1 year ago

@KyleMit Would like to review the result on https://scoop.sh/scoopinstaller-dev.github.io/ ?

KyleMit commented 1 year ago

@gpailler - that looks terrific. Very intutitive. Looks great on mobile too

gpailler commented 1 year ago

Thanks for the (positive 😊) feedback. Deployed to https://scoop.sh/