ScootKit / CustomDCBot

Create your own discord bot - Fully customizable and with a lot of features
https://scnx.xyz/bot
Other
42 stars 32 forks source link

Add starboard feature #127

Closed DEVTomatoCake closed 1 year ago

DEVTomatoCake commented 1 year ago

Resolves https://features.sc-network.net/board/2/597

Also adds a feature to sticky messages which resends them if the user changed it's configuration.

DEVTomatoCake commented 1 year ago

Additionally I observed that when a user has used all their stars in an hour removes their reaction from a starred message. this doesn't trigger an updated. This means that the star count is out-of-sync in the starred message and in the starboard message. This can create confusion (also this might lead to messages with less then the required star amount in the starboard). Please let me know if this intended behavior.

The original intention was to prevent spamming the reaction, so yes, it's intended - if you think spamming won't cause trouble, I'll change it.

SCDerox commented 1 year ago

While I agree, this is a suboptimal solution from my perspective: Instead of limiting the ability to remove the reaction (or rather count the removal of reaction), we should prevent users from adding new reactions. The reason for this is simple: We can't prevent a reaction from being removed, but we an prevent (or undo) a emoji being added. This ensures that the amount of stars under the message stays accurate with the amount of stars displayed in the starboard - from the users perspective, the current behavior appears as a bug, while preventing them from adding a new emoji is easier to understand.

DEVTomatoCake commented 1 year ago

The preventing thing already happens, doesn't it?

SCDerox commented 1 year ago

Yes, this is just about how a reaction removed after a user got "ratelimited" does not count as a removed reaction

SCDerox commented 1 year ago

Thanks for your contribution - you have received a payout as part of our Open Source Developer Program. You can find details in your SCNX organisation payout history. To pay out the received amount, please follow instructions in your dashboard. If you have any questions, please contact ScootKit staff on scnx.app/help. Cheers ✌️