ScopeLift / flexible-voting

💪🗳️ Flexible Voting – A Powerful Building Block for DAO Governance
https://flexiblevoting.com
MIT License
85 stars 8 forks source link

Partial voting signature replay issue with castVoteWithReasonAndParamsBySig + GovernorCountingFractional #50

Closed jonwalch closed 1 year ago

jonwalch commented 1 year ago

There is no nonce by default for castVoteWithReasonAndParamsBySig and _castVote depends on voting only once. This is fine for the normal flow, but partial votes by sig can be replayed in GovernorCountingFractional as long as they are still under the total voting weight of that user. Adding a nonce to bytes memory params and enforcing it would fix this issue.