ScopeLift / flexible-voting

💪🗳️ Flexible Voting – A Powerful Building Block for DAO Governance
https://flexiblevoting.com
MIT License
86 stars 8 forks source link

Update ci file #56

Closed alexkeating closed 1 year ago

alexkeating commented 1 year ago

Description

alexkeating commented 1 year ago

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

mds1 commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Interesting, seems code scanning results no longer show up in-line on PRs. Looking at the linked findings:

If you and @apbendi agree with that assessment, let's use the "Create issue" button from the respective alerts to create issues to track the fixes, and the "Dismiss alert" button with the correct reason otherwise

github-actions[bot] commented 1 year ago

Coverage after merging feature/cleanup-repo into master will be

70.45%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   FlexVotingClient.sol0%0%0%0%103, 112–113, 113, 113, 115, 115, 115–116, 118, 118, 118–120, 120, 120–122, 122, 122–123, 125, 135–136, 136, 136, 140, 158, 161, 170, 173, 176, 182, 185, 187–189, 196, 203, 209, 98
   FractionalPool.sol81.52%80%71.43%84.48%111, 114, 191, 194–195, 198, 202, 228, 239, 80, 82–83, 85
   GovernorCountingFractional.sol96.25%91.67%100%97.78%173, 176, 284