Closed apbendi closed 4 years ago
mds1
commented
4 years ago One last question and then it's good to merge, as long as you don't have anything else you wanted to do on this branch.
What is commit 878be57 for? The commit message is "Don't show Add To Cart for team grants on list page". I'm only looking at the three default grants on http://0.0.0.0:8000/grants/?network=rinkeby&category=, and I'm not sure exactly what this commit changes
apbendi
commented
4 years ago If the logged in user is a team member of the grant shown, it will not show the add to cart button on that card in the grant list.
On Sat, Jun 6, 2020 at 10:43 AM Matt notifications@github.com wrote:
One last question and then it's good to merge, as long as you don't have anything else you wanted to do on this branch.
What is commit 878be57 https://github.com/ScopeLift/gitcoin-web/commit/878be5754c7df5db9834595641d89bd230e81080 for? The commit message is "Don't show Add To Cart for team grants on list page". I'm only looking at the three default grants on http://0.0.0.0:8000/grants/?network=rinkeby&category=, and I'm not sure exactly what this commit changes
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ScopeLift/gitcoin-web/pull/18#issuecomment-640071851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJI6T63ARTG7CGKHGXCYDRVJIZNANCNFSM4NUMM27Q .
mds1
commented
4 years ago Ahh ok, it sounded like there was some other grant type called "team grants". Makes sense!
Adds side cart functionality to the Grant Details page. Currently, scrolling on this page is an issue. Fix TBD.
closes #14
Also populates tokens based on the global list, filtering based on the token the grant accepts if not all tokens. Adds the grant's accepted token to the cart data.