ScopeLift / gitcoin-web

πŸ€–Grow Open Source
https://gitcoin.co
Other
1 stars 0 forks source link

Fix error when the user is not authenticated #43

Closed zoek1 closed 4 years ago

zoek1 commented 4 years ago
Description
Refers/Fixes
Testing
TWILIO_ACCOUNT_SID=AC96cfa918514ef76e003c2a7201d92f6c
TWILIO_AUTH_TOKEN=aeeaa11392138b078s1da17e6238eb6
apbendi commented 4 years ago

Oops, sorry @owocki, I merged this before I realized you were done reviewing. I suppose if you leave feedback, @zoek1 could open another PR? My bad!

apbendi commented 4 years ago

left a few comments. @apbendi what do u think

All good thoughts @owocki, overall looked good and happy path worked properly for me. Also caught my google voice number which is πŸ‘Œ

@zoek1 if you want to address some of @owocki's comments (after discussing, if need be) feel free to open another PR. Matt is rebasing his other work on the now merged branch so it would be easier to have a new one than to back this out.

owocki commented 4 years ago

oh nice!

On Wed, Jun 10, 2020 at 3:32 PM Ben DiFrancesco notifications@github.com wrote:

left a few comments. @apbendi https://github.com/apbendi what do u think

All good thoughts @owocki https://github.com/owocki, overall looked good and happy path worked properly for me. Also caught my google voice number which is πŸ‘Œ

@zoek1 https://github.com/zoek1 if you want to address some of @owocki https://github.com/owocki's comments (after discussing, if need be) feel free to open another PR. Matt is rebasing his other work on the now merged branch so it would be easier to have a new one than to back this out.

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ScopeLift/gitcoin-web/pull/43#issuecomment-642279243, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5PCO4JFNOVFRXPLK6BHLRV73XXANCNFSM4N2N4EAQ .

--

@owocki http://www.twitter.com/owocki


gitcoin is live and has generated over $4.6mm for Open Source Software - see our results https://gitcoin.co/results