ScopeLift / gitcoin-web

🤖Grow Open Source
https://gitcoin.co
Other
1 stars 0 forks source link

Redirect after checkout, other improvements #51

Closed mds1 closed 4 years ago

mds1 commented 4 years ago

Changes:

mds1 commented 4 years ago

@apbendi This is ready to rebase and merge if you want to review it. Only thing left would be kudos support (#55) but I think @owocki will do that in a separate branch

apbendi commented 4 years ago

hey @mds1, this is a nitpick, but do you think you could squash a lot of those WIP commits. Looks like maybe all of these could just be one atomic commit for getting POSTs working?

@mds1 WIP: Begin configuring checkout POST requests 2acfa08 @mds1 WIP: Add post requests (currently failing) 1e07058 @mds1 Fix POST request: switch body to x-www-form-urlencoded f5932e3 @mds1 Add csrfmiddlewaretoken a0b3f93 @mds1 saveSubscription POST request now succeeds 0e1f6c8 @mds1 saveSplitTx POST request now succeeds 84d6c3f

mds1 commented 4 years ago

Wrong target branch (is master, should be bulk-grants), so closing this PR

mds1 commented 4 years ago

New PR: #64