ScopeLift / gitcoin-web

🤖Grow Open Source
https://gitcoin.co
Other
1 stars 0 forks source link

Throw error during checkout if any donation has a negative value #67

Closed mds1 closed 4 years ago

mds1 commented 4 years ago

If you put in negative donation amounts, the tx will go through and fail as seen in this example

https://rinkeby.etherscan.io/tx/0x51d2c0e5de8bd19dad3d335c1e3dae63d69e3889d2177399d1a3cd16b6cde306

The resolution to #63 blocks invalid numbers with arrow keys, but not typing. Throwing an error if an invalid number is entered will be a lot faster to implement then preventing the user from typing a negative number, so we'll go with that approach first

mds1 commented 4 years ago

Closed by https://github.com/gitcoinco/web/pull/6838