ScopeLift / kaspa-wallet

đź‘ť A web wallet for the Kaspa blockchain network
4 stars 2 forks source link

Setup base components, landing page, and create/open wallet pages #10

Closed mds1 closed 4 years ago

mds1 commented 4 years ago

Changes

mds1 commented 4 years ago

Agreed on all counts! But I'll give you the counterpoints to all of those which explain why we left things as they currently

We can probably get rid of the test components on the homepage, right?

We can, but my thinking was to keep it in for now as a reference, since it uses some Vue/TS syntax we haven't used elsewhere yet, and I think it will be easier to remember to reference if we consistently see the component. But of course we can always remove it and just reference it from the commit history, so I'm ok removing it if you prefer

Can we get some gutters when in desktop mode for the UI? Having the input fields extend the full page width looks rough on desktop (obviously on mobile it should span the full width).

Short answer is that yes, we can improve desktop formatting. I'll add a commit shortly

Longer answer is that @wildmolasses and I were mostly going with mobile-first development, since the desktop mockups differ pretty significantly from the mobile ones (as opposed to being pretty similar and using a responsive design). So we might want to ask them about desktop UI mockups before spending too much time on that aspect, because a responsive design will be less dev work then effectively two separate designs

I think we should ditch the screen that makes the user choose if they have a wallet or if they want to create one. This is something the system should know already, and letting the user easily create a new wallet— thus overwriting what they have in localstorage— seems risky. See the mechanics described in #11 and #13

Yep, having the app detect which page to load is the plan! For now (likely just for the next few days since Ed made some good progress) we decided to keep the landing page in until the create wallet functionality is implemented, that way it's simpler to view the Create and Open pages when developing/scaffolding those two pages

apbendi commented 4 years ago

We can, but my thinking was to keep it in for now as a reference, since it uses some Vue/TS syntax we haven't used elsewhere yet, and I think it will be easier to remember to reference if we consistently see the component.

Makes sense! That's fine.

Longer answer is that @wildmolasses and I were mostly going with mobile-first development, since the desktop mockups differ pretty significantly from the mobile ones (as opposed to being pretty similar and using a responsive design).

I agree with mobile first, but I think we should do minimum viable responsive design as it makes sense. Max-width style gutters on desktop that collapse to full width on mobile is a simple enough pattern, as are things like having components next to each other in desktop collapse into vertically stacked elements on mobile.

Yep, having the app detect which page to load is the plan! For now (likely just for the next few days since Ed made some good progress) we decided to keep the landing page in until the create wallet functionality is implemented, that way it's simpler to view the Create and Open pages when developing/scaffolding those two pages

Sounds good!

Otherwise all good, then! Approved pending the desktop margins.