ScopeLift / kaspa-wallet

👝 A web wallet for the Kaspa blockchain network
4 stars 2 forks source link

Add Fee PER BYTE Field On Send Transaction Form #81

Open apbendi opened 4 years ago

apbendi commented 4 years ago

Issue 6.1

apbendi commented 4 years ago

Update: the field is actually going to be a FEE PER BYTE field, not the final fee. The final fee get's calculated by multiplying the fee per byte they've entered by the size of the tx.

let there be a default (the minimum allowed) tx fee per byte. Let the user change the tx fee per byte. The final fee will then be displayed on the next page as the set fee per byte x the tx byte size. So in other words, the user is selecting the fee per byte, not the total fee.

wildmolasses commented 4 years ago

from chat:

wildmolasses Hi @jablonx , is size of kaspa tx equal to size in bytes of rawTransaction? i.e. 1 byte for every 2 characters of hex encoded tx? jablonx should be. and it's 1 sompi per byte

ey51 commented 4 years ago

Current state is that the fee is a hardcoded fee per byte. Adding a fee per byte field in the tx send form preloaded with the placeholder default 1 sompi per byte could be useful for testnet (we can overload the mempool with txgen, and then use the fee per byte field to test mining tx selection.