Implement efficient settable quorum without library

ScopeLift / radworks-governor-upgrade

0 stars 0 forks source link

Implement efficient settable quorum without library #15

Closed jferas closed 11 months ago

jferas commented 11 months ago

Implement settable quorum with small addition to governor bravo code

jferas commented 11 months ago

Current dependencies on/for this PR:

main
- PR #1
- PR #2
  - PR #5
  - PR #8
    - PR #12
    - PR #15 👈
    - PR #14
      - PR #19
      - PR #18
      - PR #21
        
        PR #22
    - PR #13

This stack of pull requests is managed by Graphite.

github-actions[bot] commented 11 months ago

Coverage after merging simpler-settable-quorum into main will be

77.78%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
RadworksGovernor.sol	75.51%	75%	71.43%	77.78%	106, 131–132, 140, 143, 157, 214, 89

jferas commented 11 months ago

Closing without merge.. The quorum(uint256) method, which takes a block number and expects to get the quorum at that past block. If we don't checkpoint past quorum values, we can't return the past value. This could break clients/tooling that expect it to be correct for past blocks.